Skip to content

Commit dafb4ec

Browse files
authored
[CI] Skip flaky firebase_performance driver tests (#1452)
* Skip flaky firebase_performance driver tests
1 parent 965e08f commit dafb4ec

File tree

3 files changed

+11
-3
lines changed

3 files changed

+11
-3
lines changed

packages/firebase_performance/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## 0.3.1+4
2+
3+
* Skip flaky driver tests.
4+
15
## 0.3.1+3
26

37
* Fixed analyzer warnings about unused fields.

packages/firebase_performance/example/test_driver/firebase_performance.dart

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,8 @@ void main() {
4545
});
4646
});
4747

48+
// TODO(kroikie): Update flaky test and remove skip parameter
49+
// https://github.com/FirebaseExtended/flutterfire/issues/1454.
4850
group('$Trace', () {
4951
Trace testTrace;
5052

@@ -114,8 +116,10 @@ void main() {
114116
completion(<String, String>{'yugi': 'oh'}),
115117
);
116118
});
117-
});
119+
}, skip: true);
118120

121+
// TODO(kroikie): Update flaky test and remove skip parameter
122+
// https://github.com/FirebaseExtended/flutterfire/issues/1454.
119123
group('$HttpMetric', () {
120124
HttpMetric testMetric;
121125

@@ -177,6 +181,6 @@ void main() {
177181

178182
await pumpEventQueue();
179183
});
180-
});
184+
}, skip: true);
181185
});
182186
}

packages/firebase_performance/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ description: Flutter plugin for Google Performance Monitoring for Firebase, an a
44
iOS.
55
author: Flutter Team <[email protected]>
66
homepage: https://github.com/FirebaseExtended/flutterfire/tree/master/packages/firebase_performance
7-
version: 0.3.1+3
7+
version: 0.3.1+4
88

99
dependencies:
1010
flutter:

0 commit comments

Comments
 (0)