[firebase_crashlytics] Always log crash details in debug mode (#105)

* Always log crash details in debug mode

And for Flutter error, always do it -- with FlutterError.dumpErrorToConsole,
keeping existing Flutter behavior.

* forceReport=true to dump every single FlutterError

This preserves the previous behavior of logging details of every error
caught by firebase_crashlytics plugin.

Author: dotdoom

packages/firebase_crashlytics/CHANGELOG.md

@@ -1,3 +1,8 @@
+## 0.1.1
+
+* Log FlutterErrorDetails using Flutter's standard `FlutterError.dumpErrorToConsole`.
+* In debug mode, always log errors.
+
 ## 0.1.0+5
 
 * Fix example app `support-compat` crash by setting `compileSdkVersion` to 28.

packages/firebase_crashlytics/lib/src/firebase_crashlytics.dart

@@ -28,12 +28,16 @@ class Crashlytics {
   /// to Firebase Crashlytics.
   Future<void> recordFlutterError(FlutterErrorDetails details) async {
     print('Flutter error caught by Crashlytics plugin:');
+    // Since multiple errors can be caught during a single session, we set
+    // forceReport=true.
+    FlutterError.dumpErrorToConsole(details, forceReport: true);
 
     _recordError(details.exceptionAsString(), details.stack,
         context: details.context,
         information: details.informationCollector == null
             ? null
-            : details.informationCollector());
+            : details.informationCollector(),
+        printDetails: false);
   }
 
   /// Submits a report of a non-fatal error.
@@ -200,18 +204,25 @@ class Crashlytics {
   // occurred and give useful background information in [FlutterErrorDetails.informationCollector].
   // Crashlytics will log this information in addition to the stack trace.
   // If [information] is `null` or empty, it will be ignored.
-  Future<void> _recordError(dynamic exception, StackTrace stack,
-      {dynamic context, Iterable<DiagnosticsNode> information}) async {
+  Future<void> _recordError(
+    dynamic exception,
+    StackTrace stack, {
+    dynamic context,
+    Iterable<DiagnosticsNode> information,
+    bool printDetails,
+  }) async {
     bool inDebugMode = false;
     if (!enableInDevMode) {
       assert(inDebugMode = true);
     }
 
+    printDetails ??= inDebugMode;
+
     final String _information = (information == null || information.isEmpty)
         ? ''
         : (StringBuffer()..writeAll(information, '\n')).toString();
 
-    if (inDebugMode && !enableInDevMode) {
+    if (printDetails) {
       // If available, give context to the exception.
       if (context != null)
         print('The following exception was thrown $context:');
@@ -225,7 +236,8 @@ class Crashlytics {
       // Not using Trace.format here to stick to the default stack trace format
       // that Flutter developers are used to seeing.
       if (stack != null) print('\n$stack');
-    } else {
+    }
+    if (!inDebugMode || enableInDevMode) {
       // The stack trace can be null. To avoid the following exception:
       // Invalid argument(s): Cannot create a Trace from null.
       // To avoid that exception, we can check for null and provide an empty stack trace.

packages/firebase_crashlytics/pubspec.yaml

@@ -2,7 +2,7 @@ name: firebase_crashlytics
 description:
   Flutter plugin for Firebase Crashlytics. It reports uncaught errors to the
   Firebase console.
-version: 0.1.0+5
+version: 0.1.1
 author: Flutter Team <[email protected]>
 homepage: https://github.com/FirebaseExtended/flutterfire/tree/master/packages/firebase_crashlytics