Skip to content

Commit f6dc29c

Browse files
Fix const constructors (#213)
1 parent 83a2061 commit f6dc29c

File tree

7 files changed

+34
-27
lines changed

7 files changed

+34
-27
lines changed

packages/firebase_auth/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## 0.14.0+6
2+
3+
* Update example app with correct const constructors.
4+
15
## 0.14.0+5
26

37
* On iOS, `fetchSignInMethodsForEmail` now returns an empty list when the email

packages/firebase_auth/example/lib/register_page.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ class RegisterPageState extends State<RegisterPage> {
3232
children: <Widget>[
3333
TextFormField(
3434
controller: _emailController,
35-
decoration: InputDecoration(labelText: 'Email'),
35+
decoration: const InputDecoration(labelText: 'Email'),
3636
validator: (String value) {
3737
if (value.isEmpty) {
3838
return 'Please enter some text';
@@ -42,7 +42,7 @@ class RegisterPageState extends State<RegisterPage> {
4242
),
4343
TextFormField(
4444
controller: _passwordController,
45-
decoration: InputDecoration(labelText: 'Password'),
45+
decoration: const InputDecoration(labelText: 'Password'),
4646
validator: (String value) {
4747
if (value.isEmpty) {
4848
return 'Please enter some text';

packages/firebase_auth/example/lib/signin_page.dart

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@ class SignInPageState extends State<SignInPage> {
3131
onPressed: () async {
3232
final FirebaseUser user = await _auth.currentUser();
3333
if (user == null) {
34-
Scaffold.of(context).showSnackBar(SnackBar(
35-
content: const Text('No one has signed in.'),
34+
Scaffold.of(context).showSnackBar(const SnackBar(
35+
content: Text('No one has signed in.'),
3636
));
3737
return;
3838
}
@@ -93,7 +93,7 @@ class _EmailPasswordFormState extends State<_EmailPasswordForm> {
9393
),
9494
TextFormField(
9595
controller: _emailController,
96-
decoration: InputDecoration(labelText: 'Email'),
96+
decoration: const InputDecoration(labelText: 'Email'),
9797
validator: (String value) {
9898
if (value.isEmpty) {
9999
return 'Please enter some text';
@@ -103,7 +103,7 @@ class _EmailPasswordFormState extends State<_EmailPasswordForm> {
103103
),
104104
TextFormField(
105105
controller: _passwordController,
106-
decoration: InputDecoration(labelText: 'Password'),
106+
decoration: const InputDecoration(labelText: 'Password'),
107107
validator: (String value) {
108108
if (value.isEmpty) {
109109
return 'Please enter some text';
@@ -238,7 +238,7 @@ class _EmailLinkSignInSectionState extends State<_EmailLinkSignInSection>
238238
),
239239
TextFormField(
240240
controller: _emailController,
241-
decoration: InputDecoration(labelText: 'Email'),
241+
decoration: const InputDecoration(labelText: 'Email'),
242242
validator: (String value) {
243243
if (value.isEmpty) {
244244
return 'Please enter your email.';
@@ -466,8 +466,8 @@ class _PhoneSignInSectionState extends State<_PhoneSignInSection> {
466466
),
467467
TextFormField(
468468
controller: _phoneNumberController,
469-
decoration:
470-
InputDecoration(labelText: 'Phone number (+x xxx-xxx-xxxx)'),
469+
decoration: const InputDecoration(
470+
labelText: 'Phone number (+x xxx-xxx-xxxx)'),
471471
validator: (String value) {
472472
if (value.isEmpty) {
473473
return 'Phone number (+x xxx-xxx-xxxx)';
@@ -487,7 +487,7 @@ class _PhoneSignInSectionState extends State<_PhoneSignInSection> {
487487
),
488488
TextField(
489489
controller: _smsController,
490-
decoration: InputDecoration(labelText: 'Verification code'),
490+
decoration: const InputDecoration(labelText: 'Verification code'),
491491
),
492492
Container(
493493
padding: const EdgeInsets.symmetric(vertical: 16.0),
@@ -534,9 +534,8 @@ class _PhoneSignInSectionState extends State<_PhoneSignInSection> {
534534

535535
final PhoneCodeSent codeSent =
536536
(String verificationId, [int forceResendingToken]) async {
537-
widget._scaffold.showSnackBar(SnackBar(
538-
content:
539-
const Text('Please check your phone for the verification code.'),
537+
widget._scaffold.showSnackBar(const SnackBar(
538+
content: Text('Please check your phone for the verification code.'),
540539
));
541540
_verificationId = verificationId;
542541
};
@@ -613,7 +612,7 @@ class _OtherProvidersSignInSectionState
613612
groupValue: _selection,
614613
onChanged: _handleRadioButtonSelected,
615614
),
616-
Text(
615+
const Text(
617616
'Github',
618617
style: TextStyle(fontSize: 16.0),
619618
),
@@ -622,7 +621,7 @@ class _OtherProvidersSignInSectionState
622621
groupValue: _selection,
623622
onChanged: _handleRadioButtonSelected,
624623
),
625-
Text(
624+
const Text(
626625
'Facebook',
627626
style: TextStyle(
628627
fontSize: 16.0,
@@ -633,7 +632,7 @@ class _OtherProvidersSignInSectionState
633632
groupValue: _selection,
634633
onChanged: _handleRadioButtonSelected,
635634
),
636-
Text(
635+
const Text(
637636
'Twitter',
638637
style: TextStyle(fontSize: 16.0),
639638
),
@@ -642,13 +641,14 @@ class _OtherProvidersSignInSectionState
642641
),
643642
TextField(
644643
controller: _tokenController,
645-
decoration: InputDecoration(labelText: 'Enter provider\'s token'),
644+
decoration:
645+
const InputDecoration(labelText: 'Enter provider\'s token'),
646646
),
647647
Container(
648648
child: _showAuthSecretTextField
649649
? TextField(
650650
controller: _tokenSecretController,
651-
decoration: InputDecoration(
651+
decoration: const InputDecoration(
652652
labelText: 'Enter provider\'s authTokenSecret'),
653653
)
654654
: null,

packages/firebase_auth/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ description: Flutter plugin for Firebase Auth, enabling Android and iOS
44
like Google, Facebook and Twitter.
55
author: Flutter Team <[email protected]>
66
homepage: https://github.com/FirebaseExtended/flutterfire/tree/master/packages/firebase_auth
7-
version: 0.14.0+5
7+
version: 0.14.0+6
88

99
flutter:
1010
plugin:

packages/firebase_in_app_messaging/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## 0.0.1+4
2+
3+
* Update example app with correct const constructors.
4+
15
## 0.0.1+3
26

37
* Update AGP, gradle and inappmessaging-display versions on Android.

packages/firebase_in_app_messaging/example/lib/main.dart

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ class ProgrammaticTriggersExample extends StatelessWidget {
4848
padding: const EdgeInsets.all(24.0),
4949
child: Column(
5050
children: <Widget>[
51-
Text(
51+
const Text(
5252
"Programmatic Trigger",
5353
style: TextStyle(
5454
fontStyle: FontStyle.italic,
@@ -61,8 +61,8 @@ class ProgrammaticTriggersExample extends StatelessWidget {
6161
RaisedButton(
6262
onPressed: () {
6363
fiam.triggerEvent('chicken_event');
64-
Scaffold.of(context).showSnackBar(SnackBar(
65-
content: const Text("Triggering event: chicken_event")));
64+
Scaffold.of(context).showSnackBar(const SnackBar(
65+
content: Text("Triggering event: chicken_event")));
6666
},
6767
color: Colors.blue,
6868
child: Text(
@@ -92,7 +92,7 @@ class AnalyticsEventExample extends StatelessWidget {
9292
padding: const EdgeInsets.all(24.0),
9393
child: Column(
9494
children: <Widget>[
95-
Text(
95+
const Text(
9696
"Log an analytics event",
9797
style: TextStyle(
9898
fontStyle: FontStyle.italic,
@@ -105,9 +105,8 @@ class AnalyticsEventExample extends StatelessWidget {
105105
RaisedButton(
106106
onPressed: () {
107107
_sendAnalyticsEvent();
108-
Scaffold.of(context).showSnackBar(SnackBar(
109-
content:
110-
const Text("Firing analytics event: awesome_event")));
108+
Scaffold.of(context).showSnackBar(const SnackBar(
109+
content: Text("Firing analytics event: awesome_event")));
111110
},
112111
color: Colors.blue,
113112
child: Text(

packages/firebase_in_app_messaging/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name: firebase_in_app_messaging
22
description: Flutter plugin for Firebase In-App Messaging.
3-
version: 0.0.1+3
3+
version: 0.0.1+4
44
author: Flutter Team <[email protected]>
55
homepage: https://github.com/FirebaseExtended/flutterfire/tree/master/packages/firebase_in_app_messaging
66

0 commit comments

Comments
 (0)