Skip to content

[firebase_ml_vision] Update firebase_ml_vision example app deployment target to 9.0 #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 23, 2019
Merged

[firebase_ml_vision] Update firebase_ml_vision example app deployment target to 9.0 #165

merged 3 commits into from
Sep 23, 2019

Conversation

bparrishMines
Copy link
Contributor

@bparrishMines bparrishMines commented Sep 16, 2019 •
edited
Loading

Description

Fix example in firebase_ml_vision to use minimum deployment target of API.
And fixes analyzer const warnings.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • If the pull request affects only one plugin, the PR title starts with the name of the plugin in brackets (e.g. [cloud_firestore])
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@bparrishMines bparrishMines changed the title [firebase_ml_vision] Update firebase_ml_vision deployment target to 9.0 [firebase_ml_vision] Update firebase_ml_vision example app deployment target to 9.0 Sep 16, 2019
collinjackson
collinjackson reviewed Sep 17, 2019
View reviewed changes
Copy link
Contributor

@collinjackson collinjackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm once changelog entry and pubspec.yaml are updated.

@collinjackson collinjackson self-requested a review September 17, 2019 00:22
@collinjackson collinjackson self-requested a review September 17, 2019 21:36
@bparrishMines bparrishMines merged commit 83a2061 into firebase:master Sep 23, 2019
@bparrishMines bparrishMines deleted the update_example_ml branch September 23, 2019 18:39
kroikie pushed a commit to collinjackson/flutterfire that referenced this pull request Nov 15, 2019
@bparrishMines @kroikie
[firebase_ml_vision] Update firebase_ml_vision example app deployment…
e6ae628 
… target to 9.0 (firebase#165)
@NickM-27 NickM-27 mentioned this pull request Dec 12, 2019
Closed
@besidesordinary besidesordinary mentioned this pull request May 5, 2020
Closed
@firebase firebase locked and limited conversation to collaborators Aug 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@collinjackson collinjackson collinjackson approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bparrishMines @collinjackson @googlebot