Skip to content

fix(cloud_firestore, web): stop FirebaseError appearing in console on hot restart & hot refresh #9321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 11, 2022
Merged

fix(cloud_firestore, web): stop FirebaseError appearing in console on hot restart & hot refresh #9321

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fd7edd6
fix(firestore, web): stop FirebaseError appearing in console on resta…
russellwheatley Aug 9, 2022
5b42d0d
chore(firestore, web): format
russellwheatley Aug 9, 2022
5909051
fix(firestore, web): use code to catch error from emulator when resta…
russellwheatley Aug 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion packages/cloud_firestore/cloud_firestore/lib/src/firestore.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,15 @@ class FirebaseFirestore extends FirebasePluginPlatform {
void useFirestoreEmulator(String host, int port, {bool sslEnabled = false}) {
if (kIsWeb) {
// use useEmulator() API for web as settings are set immediately unlike native platforms
_delegate.useEmulator(host, port);
try {
_delegate.useEmulator(host, port);
} catch (e) {
final String code = (e as dynamic).code;
// this catches FirebaseError from web that occurs after hot reloading & hot restarting
if (code != 'failed-precondition') {
rethrow;
}
}
} else {
String mappedHost = host;
// Android considers localhost as 10.0.2.2 - automatically handle this for users.
Expand Down