Initial sysctl tests (#53)

Author: alex

tests/run_tests.py

@@ -63,7 +63,7 @@ def main():
         )
         # TODO: qemu
         run(
-            os.path.join(BASE_DIR, path, "tests"),
+            os.path.join(BASE_DIR, path, "tests"), "--test-threads=1",
             environ=dict(
                 os.environ,
                 KERNEL_MODULE=os.path.join(BASE_DIR, "testmodule.ko")

tests/sysctl/Cargo.toml

@@ -0,0 +1,10 @@
+[package]
+name = "sysctl-tests"
+version = "0.1.0"
+authors = ["Alex Gaynor <[email protected]", "Geoffrey Thomas <[email protected]>"]
+
+[lib]
+crate-type = ["staticlib"]
+
+[dependencies]
+linux-kernel-module = { path = "../.." }

tests/sysctl/src/lib.rs

@@ -0,0 +1,30 @@
+#![no_std]
+
+use core::sync::atomic::AtomicBool;
+
+#[macro_use]
+extern crate linux_kernel_module;
+
+use linux_kernel_module::sysctl::Sysctl;
+use linux_kernel_module::Mode;
+
+struct SysctlTestModule {
+    sysctl_a: Sysctl<AtomicBool>,
+    sysctl_b: Sysctl<AtomicBool>,
+}
+
+impl linux_kernel_module::KernelModule for SysctlTestModule {
+    fn init() -> linux_kernel_module::KernelResult<Self> {
+        Ok(SysctlTestModule {
+            sysctl_a: Sysctl::register("rust/sysctl-tests\x00", "a\x00", AtomicBool::new(false), Mode::from_int(0o666))?,
+            sysctl_b: Sysctl::register("rust/sysctl-tests\x00", "b\x00", AtomicBool::new(false), Mode::from_int(0o666))?,
+        })
+    }
+}
+
+kernel_module!(
+    SysctlTestModule,
+    author: "Alex Gaynor and Geoffrey Thomas",
+    description: "A module for testing sysctls",
+    license: "GPL"
+);

tests/sysctl/tests.rs

@@ -0,0 +1,26 @@
+extern crate kernel_module_tests;
+
+use std::fs;
+
+use kernel_module_tests::with_kernel_module;
+
+#[test]
+fn test_read_bool_default() {
+    with_kernel_module(|| {
+        assert_eq!(
+            fs::read_to_string("/proc/sys/rust/sysctl-tests/a").unwrap(),
+            "0\n"
+        );
+    });
+}
+
+#[test]
+fn test_write_bool() {
+    with_kernel_module(|| {
+        fs::write("/proc/sys/rust/sysctl-tests/a", "1").unwrap();
+        assert_eq!(
+            fs::read_to_string("/proc/sys/rust/sysctl-tests/a").unwrap(),
+            "1\n"
+        );
+    });
+}

tests/testlib.rs

@@ -7,31 +7,34 @@ struct LoadedModule {
 
 impl LoadedModule {
     fn load(name: String) -> LoadedModule {
-        Command::new("sudo")
+        let status = Command::new("sudo")
             .arg("insmod")
             .arg(&name)
             .status()
             .unwrap();
+        assert!(status.success());
         return LoadedModule { name };
     }
 }
 
 impl Drop for LoadedModule {
     fn drop(&mut self) {
-        Command::new("sudo")
+        let status = Command::new("sudo")
             .arg("rmmod")
             .arg(&self.name)
             .status()
             .unwrap();
+        assert!(status.success());
     }
 }
 
 pub fn with_kernel_module<F: Fn()>(f: F) {
-    Command::new("sudo")
+    let status = Command::new("sudo")
         .arg("dmesg")
         .arg("-C")
         .status()
         .unwrap();
+    assert!(status.success());
     let _m = LoadedModule::load(env::var("KERNEL_MODULE").unwrap());
     f();
 }