Enable Wayland socket #229
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You can run vscode in native Wayland, but it only works if the socket is enabled. When the socket is enabled run: `flatpak run com.visualstudio.code --enable-features=UseOzonePlatform --ozone-platform=wayland` Note window decorations currently won't be present in GNOME when running in native Wayland.
|
Started test build 52527 |
|
Build 52527 successful |
|
If you need to pass a non-standard flag to actually make it work on Wayland, it means it's not supported by default in my book. It's fine to keep this PR open until ozone is actually enabled upstream, but you can't really claim it works under Wayland. |
|
Yes, it's no harder for the user to pass --socket=wayland than it is the other flags. |
|
This PR needs to be merged, code-oss already has the --socket=wayland flag. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can run vscode in native Wayland, but it only works if the socket is enabled.
When the socket is enabled run:
flatpak run com.visualstudio.code --enable-features=UseOzonePlatform --ozone-platform=waylandNote window decorations currently won't be present in GNOME when running in native Wayland.