Skip to content

Commit 5bf46ad

Browse files
committed
required changes for fast merging
1 parent 0f51b61 commit 5bf46ad

File tree

5 files changed

+17
-15
lines changed

5 files changed

+17
-15
lines changed

@Sources2D/Sources2D.m

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -49,21 +49,21 @@ function updateSpatial(obj, Y)
4949
end
5050

5151
%% update temporal components
52-
function Y_res = updateTemporal(obj, Y)
53-
[obj.C, obj.f, Y_res, obj.P, obj.S] = update_temporal_components(...
52+
function updateTemporal(obj, Y)
53+
[obj.C, obj.f, obj.P, obj.S] = update_temporal_components(...
5454
Y, obj.A, obj.b, obj.C, obj.f, obj.P, obj.options);
5555
end
5656

5757
%% update temporal components in parallel
58-
function Y_res = updateTemporalParallel(obj, Y)
59-
[obj.C, obj.f, Y_res, obj.P, obj.S] = update_temporal_components_parallel(...
58+
function updateTemporalParallel(obj, Y)
59+
[obj.C, obj.f, obj.P, obj.S] = update_temporal_components_parallel(...
6060
Y, obj.A, obj.b, obj.C, obj.f, obj.P, obj.options);
6161
end
6262

6363
%% merge found components
64-
function [nr, merged_ROIs] = merge(obj, Y_res)
64+
function [nr, merged_ROIs] = merge(obj, Y)
6565
[obj.A, obj.C, nr, merged_ROIs, obj.P, obj.S] = merge_components(...
66-
Y_res,obj.A, obj.b, obj.C, obj.f, obj.P,obj.S, obj.options);
66+
Y,obj.A, obj.b, obj.C, obj.f, obj.P,obj.S, obj.options);
6767
end
6868

6969
%% compute the residual

CNMFSetParms.m

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,7 @@
6363
'resparse ' % number of times that the solution is resparsened (default: 0)
6464
% MERGING (merge_ROIs.m)
6565
'merge_thr ' % merging threshold (default: 0.85)
66+
'fast_merge ' % flag for using fast merging (default 1)
6667
% VIDEO (make_patch_video.m)
6768
'ind ' % indeces of components to be shown (deafult: 1:4)
6869
'skip_frame ' % skip frames when showing the video (default: 1 (no skipping))
@@ -213,6 +214,7 @@
213214
{0}
214215
% MERGING (merge_ROIs.m)
215216
{0.85}
217+
{1}
216218
% VIDEO (make_patch_video.m)
217219
{[1:4]}
218220
{1}

demo_script.m

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -50,13 +50,13 @@
5050
[A,b] = update_spatial_components(Yr,Cin,fin,Ain,P,options);
5151

5252
%% update temporal components
53-
54-
[C,f,Y_res,P,S] = update_temporal_components(Yr,A,b,Cin,fin,P,options);
53+
% consider using update_temporal_components_parallel for increased speed
54+
[C,f,P,S] = update_temporal_components(Yr,A,b,Cin,fin,P,options);
5555

5656
%% merge found components
57-
58-
[Am,Cm,K_m,merged_ROIs,P,Sm] = merge_components(Y_res,A,b,C,f,P,S,options);
59-
57+
tic;
58+
[Am,Cm,K_m,merged_ROIs,P,Sm] = merge_components(Yr,A,b,C,f,P,S,options);
59+
toc;
6060
display_merging = 1; % flag for displaying merging example
6161
if display_merging
6262
i = 1; randi(length(merged_ROIs));
@@ -78,7 +78,7 @@
7878

7979
%% repeat
8080
[A2,b2] = update_spatial_components(Yr,Cm,f,Am,P,options);
81-
[C2,f2,Y_res,P,S2] = update_temporal_components(Yr,A2,b2,Cm,f,P,options);
81+
[C2,f2,P,S2] = update_temporal_components(Yr,A2,b2,Cm,f,P,options);
8282
[C_df,~,S_df] = extract_DF_F(Yr,[A2,b2],[C2;f2],S2,K_m+1); % extract DF/F values (optional)
8383

8484
%% do some plotting

demo_script_class.m

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -53,12 +53,12 @@
5353
updateSpatial(obj, Yr);
5454

5555
%% update temporal components
56-
Y_res = updateTemporal(obj, Yr);
56+
updateTemporal(obj, Yr);
5757

5858
%% merge found components
5959
Apr = obj.A; % store non-merged components
6060
Cpr = obj.C;
61-
[K_m, merged_ROIs] = merge(obj, Y_res);
61+
[K_m, merged_ROIs] = merge(obj, Yr);
6262
display_merging = 1; % flag for displaying merging example
6363
if display_merging
6464
i = 1; randi(length(merged_ROIs));
@@ -80,7 +80,7 @@
8080

8181
%% repeat
8282
updateSpatial(obj, Yr);
83-
Y_res = updateTemporal(obj, Yr);
83+
updateTemporal(obj, Yr);
8484
[C_df, ~, S_df] = extractDF_F(obj, Yr, K_m+1);
8585

8686
%% do some plotting

documentation.pdf

85.7 KB
Binary file not shown.

0 commit comments

Comments
 (0)