Skip to content

Commit 88cc434

Browse files
committed
add comments about ignored statements
1 parent ca895eb commit 88cc434

File tree

1 file changed

+17
-3
lines changed

1 file changed

+17
-3
lines changed

pyproject.toml

Lines changed: 17 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,14 +40,28 @@ requires = ["meson-python>=0.13", "cython>=3.0,<3.1"]
4040
build-backend = "mesonpy"
4141

4242
[tool.cython-lint]
43-
# We currently ignore
4443
# E129 visually indented line with same indent as next logical line
44+
# Reasoning: this rule is a little controversial
45+
# (see https://github.com/PyCQA/pycodestyle/issues/386)
46+
# and we ignore it to avoid needing additional indentation after
47+
# long logical statements.
48+
#
4549
# E202 whitespace before '}'
50+
# Reasoning: this rule flags up format strings f"{x = }". This is discussed
51+
# here: https://github.com/PyCQA/pycodestyle/issues/1201, as we
52+
# prefer printing whitespace around =, we disable this rule.
53+
#
4654
# E501 line too long (128 > 120 characters)
55+
# Reasoning: this is a work in progress and will be enforced once a line length
56+
# and refactor has taken place. See issue #214
57+
#
4758
# E741 ambiguous variable name
59+
# Reasoning: many places it makes sense to use l or other letters as variable
60+
# names as it is standard in mathematical notation.
61+
#
4862
# E743 ambiguous function definition
49-
# TODO: E743 should be fixed, see issue #210
50-
# E501 should be fixed once we decide line length
63+
# Reasoning: this is a work in progress and will be enforced after #210 is
64+
# resolved.
5165
max-line-length = 120
5266
ignore = ['E129','E202','E501','E741','E743']
5367
exclude = 'src/flint/flintlib/.*'

0 commit comments

Comments
 (0)