Skip to content

Commit 9e05441

Browse files
authored
[CQ] debuggability: fix order of assertSame args (#8015)
Expected and actual are flipped here which makes debugging confusing! ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read the [Flutter Style Guide] _recently_, and have followed its advice. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/master/docs/contributing/Style-guide-for-Flutter-repo.md [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/master/docs/contributing/Chat.md
1 parent 015c3b7 commit 9e05441

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

flutter-idea/testSrc/unit/io/flutter/FlutterUtilsTest.java

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -46,15 +46,15 @@ public void validPackageNames() {
4646
@Test
4747
public void zoomLevelSelector() {
4848
final ZoomLevelSelector zoomLevelSelector = new ZoomLevelSelector();
49-
assertSame(zoomLevelSelector.getClosestZoomLevel(-70), ZoomLevel.P_25);
50-
assertSame(zoomLevelSelector.getClosestZoomLevel(-10), ZoomLevel.P_25);
51-
assertSame(zoomLevelSelector.getClosestZoomLevel(0), ZoomLevel.P_25);
52-
assertSame(zoomLevelSelector.getClosestZoomLevel(1), ZoomLevel.P_25);
53-
assertSame(zoomLevelSelector.getClosestZoomLevel(20), ZoomLevel.P_25);
54-
assertSame(zoomLevelSelector.getClosestZoomLevel(28), ZoomLevel.P_25);
55-
assertSame(zoomLevelSelector.getClosestZoomLevel(35), ZoomLevel.P_33);
56-
assertSame(zoomLevelSelector.getClosestZoomLevel(222), ZoomLevel.P_200);
57-
assertSame(zoomLevelSelector.getClosestZoomLevel(226), ZoomLevel.P_250);
58-
assertSame(zoomLevelSelector.getClosestZoomLevel(700), ZoomLevel.P_500);
49+
assertSame(ZoomLevel.P_25, zoomLevelSelector.getClosestZoomLevel(-70));
50+
assertSame(ZoomLevel.P_25, zoomLevelSelector.getClosestZoomLevel(-10));
51+
assertSame(ZoomLevel.P_25, zoomLevelSelector.getClosestZoomLevel(0));
52+
assertSame(ZoomLevel.P_25, zoomLevelSelector.getClosestZoomLevel(1));
53+
assertSame(ZoomLevel.P_25, zoomLevelSelector.getClosestZoomLevel(20));
54+
assertSame(ZoomLevel.P_25, zoomLevelSelector.getClosestZoomLevel(28));
55+
assertSame(ZoomLevel.P_33, zoomLevelSelector.getClosestZoomLevel(35));
56+
assertSame(ZoomLevel.P_200, zoomLevelSelector.getClosestZoomLevel(222));
57+
assertSame(ZoomLevel.P_250, zoomLevelSelector.getClosestZoomLevel(226));
58+
assertSame(ZoomLevel.P_500, zoomLevelSelector.getClosestZoomLevel(700));
5959
}
6060
}

0 commit comments

Comments
 (0)