Skip to content

Commit a53f798

Browse files
authored
Start to remove the now deprecated Inspector view, Dart DevTools now supports all of these features (#7706)
1 parent 81f808a commit a53f798

14 files changed

+1
-2966
lines changed

flutter-idea/src/io/flutter/inspector/EvalOnDartLibrary.java

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -147,10 +147,6 @@ public String getIsolateId() {
147147
return isolateId;
148148
}
149149

150-
CompletableFuture<LibraryRef> getLibraryRef() {
151-
return libraryRef;
152-
}
153-
154150
public void dispose() {
155151
subscription.dispose();
156152
// TODO(jacobr): complete all pending futures as cancelled?
@@ -267,18 +263,6 @@ public CompletableFuture<Func> getFunc(FuncRef instance, InspectorService.Object
267263
return getObjectHelper(instance, isAlive);
268264
}
269265

270-
public CompletableFuture<Instance> getInstance(CompletableFuture<InstanceRef> instanceFuture, InspectorService.ObjectGroup isAlive) {
271-
return instanceFuture.thenComposeAsync((instance) -> getInstance(instance, isAlive));
272-
}
273-
274-
private JsonObject convertMapToJsonObject(Map<String, String> map) {
275-
final JsonObject obj = new JsonObject();
276-
for (String key : map.keySet()) {
277-
obj.addProperty(key, map.get(key));
278-
}
279-
return obj;
280-
}
281-
282266
private void initialize(String isolateId) {
283267
this.isolateId = isolateId;
284268

flutter-idea/src/io/flutter/inspector/InspectorService.java

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -453,23 +453,6 @@ private void onVmServiceReceived(String streamId, Event event) {
453453
}
454454
}
455455

456-
/**
457-
* If the widget tree is not ready, the application should wait for the next
458-
* Flutter.Frame event before attempting to display the widget tree. If the
459-
* application is ready, the next Flutter.Frame event may never come as no
460-
* new frames will be triggered to draw unless something changes in the UI.
461-
*/
462-
public CompletableFuture<Boolean> isWidgetTreeReady() {
463-
if (useServiceExtensionApi()) {
464-
return invokeServiceExtensionNoGroup("isWidgetTreeReady", new JsonObject())
465-
.thenApplyAsync(JsonElement::getAsBoolean);
466-
}
467-
else {
468-
return invokeEvalNoGroup("isWidgetTreeReady")
469-
.thenApplyAsync((InstanceRef ref) -> "true".equals(ref.getValueAsString()));
470-
}
471-
}
472-
473456
CompletableFuture<JsonElement> invokeServiceExtensionNoGroup(String methodName, List<String> args) {
474457
final JsonObject params = new JsonObject();
475458
for (int i = 0; i < args.size(); ++i) {
@@ -482,10 +465,6 @@ private CompletableFuture<Void> addPubRootDirectories(List<String> rootDirectori
482465
return invokeServiceExtensionNoGroup("addPubRootDirectories", rootDirectories).thenApplyAsync((ignored) -> null);
483466
}
484467

485-
CompletableFuture<InstanceRef> invokeEvalNoGroup(String methodName) {
486-
return getInspectorLibrary().eval("WidgetInspectorService.instance." + methodName + "()", null, null);
487-
}
488-
489468
CompletableFuture<JsonElement> invokeServiceExtensionNoGroup(String methodName, JsonObject params) {
490469
return invokeServiceExtensionHelper(methodName, params);
491470
}

flutter-idea/src/io/flutter/inspector/InspectorTree.java

Lines changed: 0 additions & 129 deletions
This file was deleted.

flutter-idea/src/io/flutter/inspector/InspectorTreeActionBase.java

Lines changed: 0 additions & 63 deletions
This file was deleted.

flutter-idea/src/io/flutter/inspector/JumpToSourceAction.java

Lines changed: 0 additions & 38 deletions
This file was deleted.

flutter-idea/src/io/flutter/inspector/JumpToSourceActionBase.java

Lines changed: 0 additions & 78 deletions
This file was deleted.

0 commit comments

Comments
 (0)