[camera] Fix crash when setting activeFormat on FLTCaptureDevice (#8630)

Fixes flutter/flutter#163295. Unfortunately Obj-C didn't provide any compile-time safety check for that.

Author: mchudy

packages/camera/camera_avfoundation/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.9.18+7
+
+* Fixes crash when setting `activeFormat` on `FLTCaptureDevice`.
+
 ## 0.9.18+6
 
 * Refactors implementations to remove remaining usage of OCMock in internal testing.

packages/camera/camera_avfoundation/ios/camera_avfoundation/Sources/camera_avfoundation/FLTCaptureDevice.m

@@ -44,8 +44,8 @@ - (AVCaptureDevicePosition)position {
   return wrappedFormats;
 }
 
-- (void)setActiveFormat:(AVCaptureDeviceFormat *)format {
-  self.device.activeFormat = format;
+- (void)setActiveFormat:(NSObject<FLTCaptureDeviceFormat> *)format {
+  self.device.activeFormat = format.format;
 }
 
 // Flash/Torch

packages/camera/camera_avfoundation/ios/camera_avfoundation/Sources/camera_avfoundation/include/camera_avfoundation/FLTCaptureDevice.h

@@ -25,9 +25,8 @@ NS_ASSUME_NONNULL_BEGIN
 - (AVCaptureDevicePosition)position;
 
 // Format/Configuration
-- (NSObject<FLTCaptureDeviceFormat> *)activeFormat;
-- (NSArray<NSObject<FLTCaptureDeviceFormat> *> *)formats;
-- (void)setActiveFormat:(NSObject<FLTCaptureDeviceFormat> *)format;
+@property(nonatomic, retain) NSObject<FLTCaptureDeviceFormat> *activeFormat;
+@property(nonatomic, readonly) NSArray<NSObject<FLTCaptureDeviceFormat> *> *formats;
 
 // Flash/Torch
 - (BOOL)hasFlash;

packages/camera/camera_avfoundation/pubspec.yaml

@@ -2,7 +2,7 @@ name: camera_avfoundation
 description: iOS implementation of the camera plugin.
 repository: https://github.com/flutter/packages/tree/main/packages/camera/camera_avfoundation
 issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+camera%22
-version: 0.9.18+6
+version: 0.9.18+7
 
 environment:
   sdk: ^3.4.0