Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Commit 95873dc

Browse files
Update CONTRIBUTING.md (#2292)
Removes obsolete recommendations about removing mockito (which is now used in testing federated plugins, see firebase/flutterfire#1472).
1 parent 95594f5 commit 95873dc

File tree

1 file changed

+0
-7
lines changed

1 file changed

+0
-7
lines changed

CONTRIBUTING.md

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -121,13 +121,6 @@ Plugins tests are run automatically on contributions using Cirrus CI. However, d
121121
cost constraints, pull requests from non-committers may not run all the tests
122122
automatically.
123123

124-
The plugins team prefers that unit tests are written using `setMockMethodCallHandler`
125-
rather than using mockito to mock out `MethodChannel`. For a list of the plugins that
126-
are still using the mockito testing style and need to be converted, see
127-
[issue 34284](https://github.com/flutter/flutter/issues/34284). If you are contributing
128-
tests to an existing plugin that uses mockito `MethodChannel`, consider converting
129-
them to use `setMockMethodCallHandler` instead.
130-
131124
Once you've gotten an LGTM from a project maintainer and once your PR has received
132125
the green light from all our automated testing, wait for one the package maintainers
133126
to merge the pull request and `pub submit` any affected packages.

0 commit comments

Comments
 (0)