🐛 Avoid clearing selected assets when disposing the provider (#428)

Author: AlexV525

CHANGELOG.md

@@ -4,6 +4,12 @@ that can be found in the LICENSE file. -->
 
 # Changelog
 
+## 8.4.2
+
+### Fixes
+
+- Avoid clearing selected assets when disposing the provider. (#428)
+
 ## 8.4.1
 
 ### Fixes

example/pubspec.yaml

@@ -1,6 +1,6 @@
 name: wechat_assets_picker_demo
 description: The demo project for the wechat_assets_picker package.
-version: 8.4.1+35
+version: 8.4.2+36
 publish_to: none
 
 environment:

lib/src/provider/asset_picker_provider.dart

@@ -56,7 +56,6 @@ abstract class AssetPickerProvider<Asset, Path> extends ChangeNotifier {
     _paths.clear();
     _currentPath = null;
     _currentAssets.clear();
-    _selectedAssets.clear();
     super.dispose();
   }
 

pubspec.yaml

@@ -1,5 +1,5 @@
 name: wechat_assets_picker
-version: 8.4.1
+version: 8.4.2
 description: |
   An image picker (also with videos and audio)
   for Flutter projects based on WeChat's UI,

test/providers_test.dart

@@ -36,5 +36,28 @@ void main() async {
       await tester.pumpAndSettle();
       expect(() => provider.addListener(() {}), throwsA(isA<AssertionError>()));
     });
+
+    /// Regression: https://github.com/fluttercandies/flutter_wechat_assets_picker/issues/427
+    testWidgets(
+      'does not clear selected assets',
+      (WidgetTester tester) async {
+        final List<AssetEntity> selectedAssets = <AssetEntity>[testAssetEntity];
+        await tester.pumpWidget(
+          defaultPickerTestApp(
+            onButtonPressed: (BuildContext context) {
+              AssetPicker.pickAssets(
+                context,
+                pickerConfig: AssetPickerConfig(selectedAssets: selectedAssets),
+              );
+            },
+          ),
+        );
+        await tester.tap(defaultButtonFinder);
+        await tester.pumpAndSettle();
+        await tester.tap(find.widgetWithIcon(IconButton, Icons.close));
+        await tester.pumpAndSettle();
+        expect(selectedAssets, contains(testAssetEntity));
+      },
+    );
   });
 }

test/test_utils.dart

@@ -98,9 +98,7 @@ class TestAssetPickerDelegate extends AssetPickerDelegate {
       filterOptions: pickerConfig.filterOptions,
     );
     provider
-      ..currentAssets = <AssetEntity>[
-        const AssetEntity(id: 'test', typeInt: 0, width: 0, height: 0),
-      ]
+      ..currentAssets = <AssetEntity>[testAssetEntity]
       ..currentPath = PathWrapper<AssetPathEntity>(
         path: pathEntity,
         assetCount: 1,
@@ -140,3 +138,10 @@ class TestAssetPickerDelegate extends AssetPickerDelegate {
     return result;
   }
 }
+
+const AssetEntity testAssetEntity = AssetEntity(
+  id: 'test',
+  typeInt: 0,
+  width: 0,
+  height: 0,
+);