Skip to content

Commit 970f8af

Browse files
committed
add method to disable features internally
Signed-off-by: Sanskar Jaiswal <[email protected]>
1 parent 7d0b285 commit 970f8af

File tree

2 files changed

+11
-4
lines changed

2 files changed

+11
-4
lines changed

internal/features/features.go

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,3 +65,11 @@ func FeatureGates() map[string]bool {
6565
func Enabled(feature string) (bool, error) {
6666
return feathelper.Enabled(feature)
6767
}
68+
69+
// Disable disables the specified feature. If the feature is not
70+
// present, it's a no-op
71+
func Disable(feature string) {
72+
if _, ok := features[feature]; ok {
73+
features[feature] = false
74+
}
75+
}

main.go

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -314,11 +314,10 @@ func main() {
314314
managed.InitManagedTransport(ctrl.Log.WithName("managed-transport"))
315315
} else {
316316
if optimize, _ := feathelper.Enabled(features.OptimizedGitClones); optimize {
317-
setupLog.Error(
318-
fmt.Errorf("OptimizedGitClones=true but GitManagedTransport=false"),
319-
"git clones can only be optimized when using managed transort",
317+
features.Disable(features.OptimizedGitClones)
318+
setupLog.Info(
319+
"disabling optimzied git clones; git clones can only be optimized when using managed transort",
320320
)
321-
os.Exit(1)
322321
}
323322
}
324323

0 commit comments

Comments
 (0)