Fix error during public key import

yebyen · yebyen · commit d400c8e9e89d · 2021-10-29T10:54:16.000-04:00
For signed commit verification, this code errors out on line 303:

✗ GitRepository reconciliation failed: ''PGP public keys secret error: expected pointer, but got nil

Pointer was not initialized with a concrete instance of the Secret struct

Signed-off-by: Kingdon Barrett &lt;yebyen@gmail.com&gt;
diff --git a/controllers/gitrepository_controller.go b/controllers/gitrepository_controller.go
@@ -298,7 +298,7 @@ func (r *GitRepositoryReconciler) reconcile(ctx context.Context, repository sour
 			Namespace: repository.Namespace,
 			Name:      repository.Spec.Verification.SecretRef.Name,
 		}
-		var secret *corev1.Secret
+		secret := &corev1.Secret{}
 		if err := r.Client.Get(ctx, publicKeySecret, secret); err != nil {
 			err = fmt.Errorf("PGP public keys secret error: %w", err)
 			return sourcev1.GitRepositoryNotReady(repository, sourcev1.VerificationFailedReason, err.Error()), err

Original file line number	Diff line number	Diff line change
`@@ -298,7 +298,7 @@ func (r *GitRepositoryReconciler) reconcile(ctx context.Context, repository sour`
`298`	`298`	`Namespace: repository.Namespace,`
`299`	`299`	`Name: repository.Spec.Verification.SecretRef.Name,`
`300`	`300`	`}`
`301`		`- var secret *corev1.Secret`
	`301`	`+ secret := &corev1.Secret{}`
`302`	`302`	`if err := r.Client.Get(ctx, publicKeySecret, secret); err != nil {`
`303`	`303`	`err = fmt.Errorf("PGP public keys secret error: %w", err)`
`304`	`304`	`return sourcev1.GitRepositoryNotReady(repository, sourcev1.VerificationFailedReason, err.Error()), err`