Skip to content

[helm-oci] Add docker-registry secrets to OCI doc #813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2022

Conversation

souleb
Copy link
Member

@souleb souleb commented Jul 4, 2022

A new statement is added to specify that docker-registry secrets are accepted by OCI Helm repositories.

Signed-off-by: Soule BA [email protected]

@souleb souleb changed the title Add docker-registry secrets to OCI doc [helm-oci] Add docker-registry secrets to OCI doc Jul 4, 2022
@souleb souleb added area/docs Documentation related issues and pull requests area/helm Helm related issues and pull requests area/oci OCI related issues and pull requests labels Jul 4, 2022
@souleb souleb force-pushed the clarify-accpeted-secret-types branch from 2098682 to c3fa47e Compare July 5, 2022 06:50
Copy link
Member

@makkes makkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we want to add an example Secret to the docs as we did for generic secrets? In any case, I'm fine with merging it as is.

@souleb
Copy link
Member Author

souleb commented Jul 5, 2022

Don't we want to add an example Secret to the docs as we did for generic secrets? In any case, I'm fine with merging it as is.

There is already an example in the website docs. Just stating here that it's possible should fine I think.

@souleb souleb force-pushed the clarify-accpeted-secret-types branch from c3fa47e to 493e8fb Compare July 12, 2022 08:16
@souleb souleb force-pushed the clarify-accpeted-secret-types branch from 493e8fb to 9acc3e1 Compare August 26, 2022 13:23
A new statement is added to specify that docker-registry secrets are
accepted by OCI Helm repositories.

Signed-off-by: Soule BA <[email protected]>
@souleb souleb force-pushed the clarify-accpeted-secret-types branch from 9acc3e1 to 6a8369f Compare August 26, 2022 13:49
@stefanprodan stefanprodan merged commit 430f507 into fluxcd:main Aug 26, 2022
@souleb souleb deleted the clarify-accpeted-secret-types branch August 29, 2022 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Documentation related issues and pull requests area/helm Helm related issues and pull requests area/oci OCI related issues and pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants