Skip to content

Merge HelmChart Reconcile tests #848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 27, 2022

Conversation

souleb
Copy link
Member

@souleb souleb commented Jul 27, 2022

If implemented this merges TestHelmChartReconciler_reconcileFromHelmRepository and TestHelmChartReconciler_Reconcile

Signed-off-by: Soule BA [email protected]

Fix: #841

If implemented this merges
TestHelmChartReconciler_reconcileFromHelmRepository and
TestHelmChartReconciler_Reconcile

Signed-off-by: Soule BA <[email protected]>
@souleb souleb force-pushed the merge-helmchart-reconcile-test branch from 2ae60d9 to fba6477 Compare July 27, 2022 12:06
Copy link
Contributor

@darkowlzz darkowlzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

@stefanprodan stefanprodan added the area/helm Helm related issues and pull requests label Jul 27, 2022
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @souleb 🎖️

@stefanprodan stefanprodan merged commit 0287457 into fluxcd:main Jul 27, 2022
@souleb souleb deleted the merge-helmchart-reconcile-test branch July 27, 2022 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/helm Helm related issues and pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Controller tests intermittently failing at CI
3 participants