fix(react-intl): use indexOf instead of includes

longlho · longlho · commit aed19a2719b8 · 2021-09-26T23:51:10.000-04:00
diff --git a/packages/react-intl/examples/BUILD b/packages/react-intl/examples/BUILD
@@ -33,8 +33,8 @@ ts_project(
     declaration_map = True,
     extends = "//:tsconfig.json",
     out_dir = "lib",
+    resolve_json_module = True,
     tsconfig = "//:tsconfig.esm.json",
-    resolve_json_module=True,
     deps = SRC_DEPS,
 )
 
diff --git a/packages/react-intl/index.ts b/packages/react-intl/index.ts
@@ -73,6 +73,7 @@ export const FormattedTime: React.FC<
       value: string | number | Date | undefined
     }
 > = createFormattedComponent('formatTime')
+// @ts-ignore issue w/ TS Intl types
 export const FormattedNumber: React.FC<
   NumberFormatOptions &
     CustomFormatConfig & {
diff --git a/packages/react-intl/src/components/relative.tsx b/packages/react-intl/src/components/relative.tsx
@@ -78,7 +78,7 @@ const INCREMENTABLE_UNITS: RelativeTimeFormatSingularUnit[] = [
 function canIncrement(
   unit: RelativeTimeFormatSingularUnit = 'second'
 ): boolean {
-  return INCREMENTABLE_UNITS.includes(unit)
+  return INCREMENTABLE_UNITS.indexOf(unit) > -1
 }
 
 const SimpleFormattedRelativeTime: React.FC<

Original file line number	Diff line number	Diff line change
`@@ -73,6 +73,7 @@ export const FormattedTime: React.FC<`
`73`	`73`	`value: string \| number \| Date \| undefined`
`74`	`74`	`}`
`75`	`75`	`> = createFormattedComponent('formatTime')`
	`76`	`+// @ts-ignore issue w/ TS Intl types`
`76`	`77`	`export const FormattedNumber: React.FC<`
`77`	`78`	`NumberFormatOptions &`
`78`	`79`	`CustomFormatConfig & {`
Original file line number	Diff line number	Diff line change
`@@ -78,7 +78,7 @@ const INCREMENTABLE_UNITS: RelativeTimeFormatSingularUnit[] = [`
`78`	`78`	`function canIncrement(`
`79`	`79`	`unit: RelativeTimeFormatSingularUnit = 'second'`
`80`	`80`	`): boolean {`
`81`		`- return INCREMENTABLE_UNITS.includes(unit)`
	`81`	`+ return INCREMENTABLE_UNITS.indexOf(unit) > -1`
`82`	`82`	`}`
`83`	`83`
`84`	`84`	`const SimpleFormattedRelativeTime: React.FC<`