Skip to content

Commit f03e6d3

Browse files
committed
Wrap test cleanup calls in finally blocks
Signed-off-by: Sahas Subramanian <[email protected]>
1 parent 919a0f4 commit f03e6d3

File tree

3 files changed

+42
-39
lines changed

3 files changed

+42
-39
lines changed

tests/timeseries/_battery_pool/test_battery_pool_control_methods.py

Lines changed: 14 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -71,19 +71,20 @@ async def mocks(mocker: MockerFixture) -> typing.AsyncIterator[Mocks]:
7171
dp = microgrid._data_pipeline._DATA_PIPELINE
7272
assert dp is not None
7373

74-
yield Mocks(
75-
mockgrid,
76-
streamer,
77-
dp._battery_power_wrapper.status_channel.new_sender(),
78-
)
79-
80-
await asyncio.gather(
81-
*[
82-
dp._stop(),
83-
streamer.stop(),
84-
mockgrid.cleanup(),
85-
]
86-
)
74+
try:
75+
yield Mocks(
76+
mockgrid,
77+
streamer,
78+
dp._battery_power_wrapper.status_channel.new_sender(),
79+
)
80+
finally:
81+
_ = await asyncio.gather(
82+
*[
83+
dp._stop(),
84+
streamer.stop(),
85+
mockgrid.cleanup(),
86+
]
87+
)
8788

8889

8990
class TestBatteryPoolControl:

tests/timeseries/_ev_charger_pool/test_ev_charger_pool_control_methods.py

Lines changed: 14 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -57,19 +57,20 @@ async def mocks(mocker: MockerFixture) -> typing.AsyncIterator[_Mocks]:
5757

5858
dp = typing.cast(_DataPipeline, microgrid._data_pipeline._DATA_PIPELINE)
5959

60-
yield _Mocks(
61-
mockgrid,
62-
streamer,
63-
dp._ev_power_wrapper.status_channel.new_sender(),
64-
)
65-
66-
await asyncio.gather(
67-
*[
68-
dp._stop(),
69-
streamer.stop(),
70-
mockgrid.cleanup(),
71-
]
72-
)
60+
try:
61+
yield _Mocks(
62+
mockgrid,
63+
streamer,
64+
dp._ev_power_wrapper.status_channel.new_sender(),
65+
)
66+
finally:
67+
_ = await asyncio.gather(
68+
*[
69+
dp._stop(),
70+
streamer.stop(),
71+
mockgrid.cleanup(),
72+
]
73+
)
7374

7475

7576
class TestEVChargerPoolControl:

tests/timeseries/_pv_pool/test_pv_pool_control_methods.py

Lines changed: 14 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -50,19 +50,20 @@ async def mocks(mocker: MockerFixture) -> typing.AsyncIterator[_Mocks]:
5050

5151
dp = typing.cast(_DataPipeline, microgrid._data_pipeline._DATA_PIPELINE)
5252

53-
yield _Mocks(
54-
mockgrid,
55-
streamer,
56-
dp._pv_power_wrapper.status_channel.new_sender(),
57-
)
58-
59-
await asyncio.gather(
60-
*[
61-
dp._stop(),
62-
streamer.stop(),
63-
mockgrid.cleanup(),
64-
]
65-
)
53+
try:
54+
yield _Mocks(
55+
mockgrid,
56+
streamer,
57+
dp._pv_power_wrapper.status_channel.new_sender(),
58+
)
59+
finally:
60+
_ = await asyncio.gather(
61+
*[
62+
dp._stop(),
63+
streamer.stop(),
64+
mockgrid.cleanup(),
65+
]
66+
)
6667

6768

6869
class TestPVPoolControl:

0 commit comments

Comments
 (0)