bug #735 Fix TypeScript warnings (bocharsky-bw, weaverryan)

This PR was merged into the 2.x branch.

Discussion
----------

Fix TypeScript warnings

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Tickets       | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License       | MIT

If you run `yarn build` there are quite a few TS warnings. This happened because we originally didn't use TypeScript, so when we switched, a lot of "types" were missing.

I'm not sure how to fix the last one remaining here:
```
src/Notify/assets/src/controller.ts → src/Notify/assets/dist/controller.js...
(!) Plugin typescript: `@rollup`/plugin-typescript TS2769: No overload matches this call.
  Overload 1 of 3, '(type: "message", listener: (this: EventSource, ev: MessageEvent<any>) => any, options?: boolean | EventListenerOptions | undefined): void', gave the following error.
    Argument of type '(content: string | undefined) => void' is not assignable to parameter of type '(this: EventSource, ev: MessageEvent<any>) => any'.
      Types of parameters 'content' and 'ev' are incompatible.
        Type 'MessageEvent<any>' is not assignable to type 'string'.
  Overload 2 of 3, '(type: string, listener: (this: EventSource, event: MessageEvent<any>) => any, options?: boolean | EventListenerOptions | undefined): void', gave the following error.
    Argument of type '(content: string | undefined) => void' is not assignable to parameter of type '(this: EventSource, event: MessageEvent<any>) => any'.
      Types of parameters 'content' and 'event' are incompatible.
        Type 'MessageEvent<any>' is not assignable to type 'string'.
  Overload 3 of 3, '(type: string, listener: EventListenerOrEventListenerObject, options?: boolean | EventListenerOptions | undefined): void', gave the following error.
    Argument of type '(content: string | undefined) => void' is not assignable to parameter of type 'EventListenerOrEventListenerObject'.
      Type '(content: string | undefined) => void' is not assignable to type 'EventListener'.
        Types of parameters 'content' and 'evt' are incompatible.
          Type 'Event' is not assignable to type 'string'.
src/Notify/assets/src/controller.ts: (61:56)

61             eventSource.removeEventListener('message', this._notify);
                                                          ~~~~~~~~~~~~
created src/Notify/assets/dist/controller.js in 926ms
```

If anyone has ideas how to fix - please, share :)

Depreciations like "(!) Plugin commonjs: The namedExports option from "`@rollup`/plugin-commonjs" is deprecated. Named exports are now handled automatically." were fixed in symfony/ux#734

Commits
-------

5c585f22 [Notify] Fixing bug where disconnecting was not precisely disconnecting the correct thing
50ecc6f6 Fix TypeScript warnings

Author: fullstackdeveloperwebapp

.github/workflows/test.yaml

@@ -15,6 +15,7 @@ jobs:
               run: ./vendor/bin/php-cs-fixer fix --dry-run --diff
 
     coding-style-js:
+        name: JavaScript Coding Style
         runs-on: ubuntu-latest
         steps:
             - uses: actions/checkout@master
@@ -33,6 +34,7 @@ jobs:
             - run: yarn check-format
 
     js-dist-current:
+        name: Check for UnBuilt JS Dist Files
         runs-on: ubuntu-latest
         steps:
             - uses: actions/checkout@master
@@ -49,12 +51,18 @@ jobs:
             - run: yarn && yarn build
             - name: Check if js dist files are current
               id: changes
-              uses: UnicornGlobal/[email protected]
+              run: |
+                echo "STATUS=$(git status --porcelain)" >> $GITHUB_OUTPUT
 
-            - name: Ensure no changes
-              if: steps.changes.outputs.changed == 1
+            - name: No changes found
+              if: steps.changes.outputs.STATUS == ''
+              run: |
+                echo "git status is clean"
+            - name: Changes were found
+              if: steps.changes.outputs.STATUS != ''
               run: |
                 echo "JS dist files need to be rebuilt"
+                echo "${{ steps.changes.outputs.STATUS }}"
                 exit 1
 
     tests-php-low-deps:

src/Autocomplete/assets/dist/controller.js

@@ -1,25 +1,25 @@
 import { Controller } from '@hotwired/stimulus';
 import TomSelect from 'tom-select';
 
-/******************************************************************************
-Copyright (c) Microsoft Corporation.
-
-Permission to use, copy, modify, and/or distribute this software for any
-purpose with or without fee is hereby granted.
-
-THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES WITH
-REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF MERCHANTABILITY
-AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY SPECIAL, DIRECT,
-INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM
-LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR
-OTHER TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR
-PERFORMANCE OF THIS SOFTWARE.
-***************************************************************************** */
-
-function __classPrivateFieldGet(receiver, state, kind, f) {
-    if (kind === "a" && !f) throw new TypeError("Private accessor was defined without a getter");
-    if (typeof state === "function" ? receiver !== state || !f : !state.has(receiver)) throw new TypeError("Cannot read private member from an object whose class did not declare it");
-    return kind === "m" ? f : kind === "a" ? f.call(receiver) : f ? f.value : state.get(receiver);
+/******************************************************************************
+Copyright (c) Microsoft Corporation.
+
+Permission to use, copy, modify, and/or distribute this software for any
+purpose with or without fee is hereby granted.
+
+THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES WITH
+REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF MERCHANTABILITY
+AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY SPECIAL, DIRECT,
+INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM
+LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR
+OTHER TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR
+PERFORMANCE OF THIS SOFTWARE.
+***************************************************************************** */
+
+function __classPrivateFieldGet(receiver, state, kind, f) {
+    if (kind === "a" && !f) throw new TypeError("Private accessor was defined without a getter");
+    if (typeof state === "function" ? receiver !== state || !f : !state.has(receiver)) throw new TypeError("Cannot read private member from an object whose class did not declare it");
+    return kind === "m" ? f : kind === "a" ? f.call(receiver) : f ? f.value : state.get(receiver);
 }
 
 var _default_1_instances, _default_1_getCommonConfig, _default_1_createAutocomplete, _default_1_createAutocompleteWithHtmlContents, _default_1_createAutocompleteWithRemoteData, _default_1_stripTags, _default_1_mergeObjects, _default_1_createTomSelect;
@@ -193,7 +193,7 @@ class default_1 extends Controller {
             this.resetTomSelect();
         }
         if (changeDisabledState) {
-            this.changeTomSelectDisabledState((this.formElement.disabled));
+            this.changeTomSelectDisabledState(this.formElement.disabled);
         }
         if (changePlaceholder) {
             this.updateTomSelectPlaceholder();

src/Chartjs/assets/dist/controller.js

@@ -30,7 +30,7 @@ class default_1 extends Controller {
             const parentElement = this.element.parentElement;
             if (parentElement && this.chart.options.responsive) {
                 const originalWidth = parentElement.style.width;
-                parentElement.style.width = (parentElement.offsetWidth + 1) + 'px';
+                parentElement.style.width = parentElement.offsetWidth + 1 + 'px';
                 setTimeout(() => {
                     parentElement.style.width = originalWidth;
                 }, 0);

src/LiveComponent/assets/dist/ComponentRegistry.d.ts

@@ -0,0 +1,9 @@
+import Component from './Component';
+declare class ComponentRegistry {
+    private components;
+    registerComponent(element: HTMLElement, definition: Component): void;
+    unregisterComponent(element: HTMLElement): void;
+    getComponent(element: HTMLElement): Promise<Component>;
+}
+declare const _default: ComponentRegistry;
+export default _default;