Add expectations for success responses

Because many methods only have expectations against variables assigned, nothing is currently specified that can be checked in Rails 5, where assigns checking is not included. This commit adds an expectation of the HTTP response code for each method, unless a redirect is specified (which is implicitly a 301 or 302).

Author: Josh Justice

lib/generators/rspec/scaffold/templates/controller_spec.rb

@@ -48,6 +48,16 @@
 <% end -%>
       expect(assigns(:<%= table_name %>)).to eq([<%= file_name %>])
     end
+
+    it "returns a success response" do
+      <%= file_name %> = <%= class_name %>.create! valid_attributes
+<% if RUBY_VERSION < '1.9.3' -%>
+      get :index, {}, valid_session
+<% else -%>
+      get :index, params: {}, session: valid_session
+<% end -%>
+      expect(response).to be_success
+    end
   end
 
 <% end -%>
@@ -61,6 +71,16 @@
 <% end -%>
       expect(assigns(:<%= ns_file_name %>)).to eq(<%= file_name %>)
     end
+
+    it "returns a success response" do
+      <%= file_name %> = <%= class_name %>.create! valid_attributes
+<% if RUBY_VERSION < '1.9.3' -%>
+      get :show, {:id => <%= file_name %>.to_param}, valid_session
+<% else -%>
+      get :show, params: {id: <%= file_name %>.to_param}, session: valid_session
+<% end -%>
+      expect(response).to be_success
+    end
   end
 
   describe "GET #new" do
@@ -72,6 +92,15 @@
 <% end -%>
       expect(assigns(:<%= ns_file_name %>)).to be_a_new(<%= class_name %>)
     end
+
+    it "returns a success response" do
+<% if RUBY_VERSION < '1.9.3' -%>
+      get :new, {}, valid_session
+<% else -%>
+      get :new, params: {}, session: valid_session
+<% end -%>
+      expect(response).to be_success
+    end
   end
 
   describe "GET #edit" do
@@ -84,6 +113,16 @@
 <% end -%>
       expect(assigns(:<%= ns_file_name %>)).to eq(<%= file_name %>)
     end
+
+    it "returns a success response" do
+      <%= file_name %> = <%= class_name %>.create! valid_attributes
+<% if RUBY_VERSION < '1.9.3' -%>
+      get :edit, {:id => <%= file_name %>.to_param}, valid_session
+<% else -%>
+      get :edit, params: {id: <%= file_name %>.to_param}, session: valid_session
+<% end -%>
+      expect(response).to be_success
+    end
   end
 
   describe "POST #create" do
@@ -128,6 +167,15 @@
         expect(assigns(:<%= ns_file_name %>)).to be_a_new(<%= class_name %>)
       end
 
+      it "returns a success response (i.e. to display the 'new' template)" do
+<% if RUBY_VERSION < '1.9.3' -%>
+        post :create, {:<%= ns_file_name %> => invalid_attributes}, valid_session
+<% else -%>
+        post :create, params: {<%= ns_file_name %>: invalid_attributes}, session: valid_session
+<% end -%>
+        expect(response).to be_success
+      end
+
       it "re-renders the 'new' template" do
 <% if RUBY_VERSION < '1.9.3' -%>
         post :create, {:<%= ns_file_name %> => invalid_attributes}, valid_session
@@ -188,6 +236,16 @@
         expect(assigns(:<%= ns_file_name %>)).to eq(<%= file_name %>)
       end
 
+      it "returns a success response (i.e. to display the 'edit' template)" do
+        <%= file_name %> = <%= class_name %>.create! valid_attributes
+<% if RUBY_VERSION < '1.9.3' -%>
+        put :update, {:id => <%= file_name %>.to_param, :<%= ns_file_name %> => invalid_attributes}, valid_session
+<% else -%>
+        put :update, params: {id: <%= file_name %>.to_param, <%= ns_file_name %>: invalid_attributes}, session: valid_session
+<% end -%>
+        expect(response).to be_success
+      end
+
       it "re-renders the 'edit' template" do
         <%= file_name %> = <%= class_name %>.create! valid_attributes
 <% if RUBY_VERSION < '1.9.3' -%>