Omit an id attribute from "scaffold/templates"

From Rails 5.1, a form view which is generated by scaffold command
uses `form_with`.
`form_with` does not append id attribute for form tags or input tags.
So our templates should not use id selectors.

rails/rails@d3b798b

Author: yui-knk

lib/generators/rspec/scaffold/templates/edit_spec.rb

@@ -16,7 +16,11 @@
     assert_select "form[action=?][method=?]", <%= ns_file_name %>_path(@<%= ns_file_name %>), "post" do
 <% for attribute in output_attributes -%>
       <%- name = attribute.respond_to?(:column_name) ? attribute.column_name : attribute.name %>
+<% if Rails.version.to_f >= 5.1 -%>
+      assert_select "<%= attribute.input_type -%>[name=?]", "<%= ns_file_name %>[<%= name %>]"
+<% else -%>
       assert_select "<%= attribute.input_type -%>#<%= ns_file_name %>_<%= name %>[name=?]", "<%= ns_file_name %>[<%= name %>]"
+<% end -%>
 <% end -%>
     end
   end

lib/generators/rspec/scaffold/templates/new_spec.rb

@@ -15,7 +15,11 @@
     assert_select "form[action=?][method=?]", <%= index_helper %>_path, "post" do
 <% for attribute in output_attributes -%>
       <%- name = attribute.respond_to?(:column_name) ? attribute.column_name : attribute.name %>
+<% if Rails.version.to_f >= 5.1 -%>
+      assert_select "<%= attribute.input_type -%>[name=?]", "<%= ns_file_name %>[<%= name %>]"
+<% else -%>
       assert_select "<%= attribute.input_type -%>#<%= ns_file_name %>_<%= name %>[name=?]", "<%= ns_file_name %>[<%= name %>]"
+<% end -%>
 <% end -%>
     end
   end

spec/generators/rspec/scaffold/scaffold_generator_spec.rb

@@ -111,7 +111,23 @@
       it { is_expected.to contain('assert_select "tr>td", :text => 3.5.to_s, :count => 2') }
     end
 
-    if Rails.version.to_f >= 4.0
+    case
+    when Rails.version.to_f >= 5.1
+      describe 'with reference attribute' do
+        before { run_generator %w(posts title:string author:references) }
+        describe 'edit' do
+          subject { file("spec/views/posts/edit.html.erb_spec.rb") }
+          it { is_expected.to contain(/assert_select "input\[name=\?\]", "post\[author_id\]/) }
+          it { is_expected.to contain(/assert_select "input\[name=\?\]", "post\[title\]/) }
+        end
+
+        describe 'new' do
+          subject { file("spec/views/posts/new.html.erb_spec.rb") }
+          it { is_expected.to contain(/assert_select "input\[name=\?\]", "post\[author_id\]"/) }
+          it { is_expected.to contain(/assert_select "input\[name=\?\]", "post\[title\]/) }
+        end
+      end
+    when Rails.version.to_f >= 4.0
       describe 'with reference attribute' do
         before { run_generator %w(posts title:string author:references) }
         describe 'edit' do