Skip to content

Commit af211e7

Browse files
benoittgtsebjacobs
authored andcommitted
Implement comments review from Ashley on rspec#1705
1 parent 7d5a2e7 commit af211e7

File tree

2 files changed

+28
-21
lines changed

2 files changed

+28
-21
lines changed

CONTRIBUTING.md

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24,27 +24,31 @@ If you need help getting started, check out the [DEVELOPMENT](DEVELOPMENT.md) fi
2424

2525
Thanks for helping us make RSpec better!
2626

27-
## `Small` issues
27+
## Rspec issues labels definition
28+
29+
### `Your first PR` issues
2830

2931
These issues are the ones that we be believe are best suited for new
3032
contributors to get started on. They represent a potential meaningful
3133
contribution to the project that should not be too hard to pull off.
3234

33-
## `Triage` issues
35+
### `Needs reproduction case` issues
3436

3537
These issues are ones that have been labelled by the maintainers that we
3638
believe do not currently have enough information to be reproduced the RSpec
3739
team. While not directly counted by the GitHub contribution graph, we consider
38-
helping us triage issues to the point where they can be reproduced as an
39-
extremely meaningful contribution.
40+
helping us to reproduced the issue with a repro case as an extremely meaningful
41+
contribution.
4042

41-
## `Has reproduction case` issues
43+
### `Has reproduction case` issues
4244

4345
Issues that have reproduction cases have a repository that we can clone that
4446
enable us to quickly determine the issue is valid and then start debugging
4547
within RSpec. These issues are good ones to tackle to help us actively fix bugs.
4648

47-
## Maintenance branches
49+
## Dev environment
50+
51+
### Maintenance branches
4852

4953
Maintenance branches are how we manage the different supported point releases
5054
of RSpec. As such, while they might look like good candidates to merge into

ISSUE_TEMPLATE.md

Lines changed: 18 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,24 @@ resolve your bug faster!
1414
1515
-->
1616

17+
## What Ruby, Rails and RSpec versions are you using?
18+
19+
Ruby version:
20+
Rails version:
21+
Rspec version:
22+
23+
<!--
24+
25+
You can run
26+
27+
```
28+
bundle exec ruby --version
29+
bundle exec rails --version
30+
bundle exec rspec --version
31+
```
32+
33+
-->
34+
1735
## Observed behaviour
1836

1937
<!--
@@ -45,21 +63,6 @@ your issue, and we typically ask that you follow these steps:
4563
5. Provide a link to a github repo, a description of the app and what you're expecting here
4664
-->
4765

48-
## What Ruby, Rails and RSpec versions are you using?
49-
50-
<!--
51-
52-
You can run
53-
54-
```
55-
bundle exec ruby --version
56-
bundle exec rails --version
57-
bundle exec rspec --version
58-
```
59-
60-
and paste the output below
61-
62-
-->
6366

6467
## Did this problem exist before you upgraded to Rails 5?
6568

0 commit comments

Comments
 (0)