- Fix: Filtering tags (as with lodash) to allow for missing array; add test

Author: brettz9

src/iterateJsdoc.js

@@ -173,11 +173,7 @@ const curryUtils = (
   };
 
   utils.getTags = (tagName) => {
-    if (!jsdoc.tags) {
-      return [];
-    }
-
-    return jsdoc.tags.filter((item) => {
+    return utils.filterTags((item) => {
       return item.tag === tagName;
     });
   };
@@ -186,6 +182,10 @@ const curryUtils = (
     return forceRequireReturn;
   };
 
+  utils.filterTags = (filter) => {
+    return (jsdoc.tags || []).filter(filter);
+  };
+
   utils.getClassNode = () => {
     const greatGrandParent = ancestors.slice(-3)[0];
     const greatGrandParentValue = greatGrandParent && sourceCode.getFirstToken(greatGrandParent).value;

src/rules/checkTypes.js

@@ -15,13 +15,12 @@ const strictNativeTypes = [
 ];
 
 export default iterateJsdoc(({
-  jsdoc,
   jsdocNode,
   sourceCode,
   report,
   utils
 }) => {
-  const jsdocTags = jsdoc.tags.filter((tag) => {
+  const jsdocTags = utils.filterTags((tag) => {
     return utils.isTagWithType(tag.tag);
   });
 

src/rules/matchDescription.js

@@ -6,7 +6,8 @@ const tagsWithDescriptions = ['param', 'arg', 'argument', 'returns', 'return'];
 export default iterateJsdoc(({
   jsdoc,
   report,
-  context
+  context,
+  utils
 }) => {
   const options = context.options[0] || {};
 
@@ -38,7 +39,7 @@ export default iterateJsdoc(({
     return;
   }
 
-  const tags = jsdoc.tags.filter(({tag}) => {
+  const tags = utils.filterTags(({tag}) => {
     return tagsWithDescriptions.includes(tag) &&
       {}.hasOwnProperty.call(options.tags, tag) && options.tags[tag];
   });

src/rules/noUndefinedTypes.js

@@ -9,7 +9,6 @@ const extraTypes = [
 
 export default iterateJsdoc(({
   context,
-  jsdoc,
   report,
   sourceCode,
   utils
@@ -54,7 +53,7 @@ export default iterateJsdoc(({
     .concat(extraTypes)
     .concat(typedefDeclarations);
 
-  const jsdocTags = jsdoc.tags.filter((tag) => {
+  const jsdocTags = utils.filterTags((tag) => {
     return utils.isTagWithType(tag.tag);
   });
 

test/rules/assertions/noUndefinedTypes.js

@@ -166,6 +166,17 @@ export default {
         callback();
       }
       `
+    },
+    {
+      code: `
+      /**
+       *
+       *
+       */
+      function foo () {
+
+      }
+      `
     }
   ]
 };