Parse multiple template types in one tag

Author: l1bbcsg

src/jsdocUtils.js

@@ -455,6 +455,22 @@ const isInlineTag = (tag) => {
 };
 */
 
+/**
+ * Parses GCC Generic/Template types
+ *
+ * @see {https://github.com/google/closure-compiler/wiki/Generic-Types}
+ * @param {JsDocTag} tag
+ * @returns {Array<string>}
+ */
+const parseClosureTemplateTag = (tag) => {
+  return tag.source
+    .split('@template')[1]
+    .split(',')
+    .map((type) => {
+      return type.trim();
+    });
+};
+
 export default {
   getFunctionParameterNames,
   getJsdocParameterNames,
@@ -468,5 +484,6 @@ export default {
   isNamepathTag,
   isPotentiallyEmptyNamepathTag,
   isTagWithType,
-  isValidTag
+  isValidTag,
+  parseClosureTemplateTag
 };

src/rules/noUndefinedTypes.js

@@ -1,6 +1,7 @@
 import _ from 'lodash';
 import {parse as parseType, traverse} from 'jsdoctypeparser';
 import iterateJsdoc, {parseComment} from '../iterateJsdoc';
+import jsdocUtils from '../jsdocUtils';
 
 const extraTypes = [
   'null', 'undefined', 'string', 'boolean', 'object',
@@ -63,12 +64,12 @@ export default iterateJsdoc(({
   let closureGenericTypes = [];
   const classJsdoc = utils.getClassJsdoc();
   if (classJsdoc && classJsdoc.tags) {
-    closureGenericTypes = classJsdoc.tags
+    classJsdoc.tags
       .filter((tag) => {
         return tag.tag === 'template';
       })
-      .map((tag) => {
-        return tag.name;
+      .forEach((tag) => {
+        closureGenericTypes = closureGenericTypes.concat(jsdocUtils.parseClosureTemplateTag(tag));
       });
   }
 

test/rules/assertions/noUndefinedTypes.js

@@ -340,6 +340,21 @@ export default {
         }
       }
       `
+    },
+    {
+      code: `
+      /**
+       * @template TEMPLATE_TYPE_A, TEMPLATE_TYPE_B
+       */
+      class Foo {
+        /**
+         * @param {TEMPLATE_TYPE_A} baz
+         * @return {TEMPLATE_TYPE_B}
+         */
+        bar (baz) {
+        }
+      }
+      `
     }
   ]
 };