Fixed up defaulting and such

Author: JoshuaKGoldberg

README.md

@@ -4605,14 +4605,14 @@ let a;
 /** @abstract */
 let a;
 // "jsdoc/check-tag-names": ["error"|"warn", {"typed":true}]
-// Message: '@abstract' is generally redundant outside of `declare` contexts when using a type system.
+// Message: '@abstract' is redundant outside of ambient (`declare`/`.d.ts`) contexts when using a type system.
 
 const a = {
   /** @abstract */
   b: true,
 };
 // "jsdoc/check-tag-names": ["error"|"warn", {"typed":true}]
-// Message: '@abstract' is generally redundant outside of `declare` contexts when using a type system.
+// Message: '@abstract' is redundant outside of ambient (`declare`/`.d.ts`) contexts when using a type system.
 
 /** @template */
 let a;
@@ -4984,6 +4984,14 @@ function Test() {
 The following patterns are not considered problems:
 
 ````js
+/** @default 0 */
+let a;
+// "jsdoc/check-tag-names": ["error"|"warn", {"typed":true}]
+
+/** @default 0 */
+declare let a;
+// "jsdoc/check-tag-names": ["error"|"warn", {"typed":true}]
+
 /** @abstract */
 let a;
 // "jsdoc/check-tag-names": ["error"|"warn", {"typed":true}]
@@ -5002,13 +5010,9 @@ function test() {
 }
 // "jsdoc/check-tag-names": ["error"|"warn", {"typed":true}]
 
-/** @abstract - default */
-let a;
-// "jsdoc/check-tag-names": ["error"|"warn", {"typed":true}]
-
 /** @template name */
 let a;
-// "jsdoc/check-tag-names": ["error"|"warn", {"definedTags":["template"],"typed":true}]
+// "jsdoc/check-tag-names": ["error"|"warn", {"typed":true}]
 
 /** @param param - takes information */
 function takesOne(param) {}

src/rules/checkTagNames.js

@@ -25,6 +25,10 @@ const typedTagsAlwaysUnnecessary = new Set([
   'typedef',
 ]);
 
+const typedTagsNeedingName = new Set([
+  'template',
+]);
+
 const typedTagsUnnecessaryOutsideDeclare = new Set([
   'abstract',
   'access',
@@ -114,7 +118,7 @@ export default iterateJsdoc(({
       return false;
     }
 
-    if (jsdocTag.name === 'default') {
+    if (jsdocTag.tag === 'default') {
       return false;
     }
 
@@ -159,8 +163,8 @@ export default iterateJsdoc(({
       return true;
     }
 
-    if (jsdocTag.tag === 'template' && !jsdocTag.name) {
-      reportWithTypeRemovalFixer('\'@template\' without a name is redundant when using a type system.', jsdocTag, tagIndex);
+    if (typedTagsNeedingName.has(jsdocTag.tag) && !jsdocTag.name) {
+      reportWithTypeRemovalFixer(`'@${jsdocTag.tag}' without a name is redundant when using a type system.`, jsdocTag, tagIndex);
       return true;
     }
 
@@ -178,10 +182,15 @@ export default iterateJsdoc(({
       continue;
     }
 
-    if (utils.isValidTag(tagName, [
-      ...definedTags, ...definedPreferredTags, ...definedNonPreferredTags,
+    const validTags = [
+      ...definedTags,
+      ...definedPreferredTags,
+      ...definedNonPreferredTags,
       ...definedStructuredTags,
-    ])) {
+      ...typed ? typedTagsNeedingName : [],
+    ];
+
+    if (utils.isValidTag(tagName, validTags)) {
       let preferredTagName = utils.getPreferredTagName({
         allowObjectReturn: true,
         defaultMessage: `Blacklisted tag found (\`@${tagName}\`)`,

test/rules/assertions/checkTagNames.js

@@ -885,6 +885,32 @@ export default {
     },
   ],
   valid: [
+    {
+      code: `
+        /** @default 0 */
+        let a;
+      `,
+      filename: 'file.ts',
+      options: [
+        {
+          typed: true,
+        },
+      ],
+      parser: require.resolve('@typescript-eslint/parser'),
+    },
+    {
+      code: `
+        /** @default 0 */
+        declare let a;
+      `,
+      filename: 'file.d.ts',
+      options: [
+        {
+          typed: true,
+        },
+      ],
+      parser: require.resolve('@typescript-eslint/parser'),
+    },
     {
       code: `
         /** @abstract */
@@ -945,9 +971,6 @@ export default {
       `,
       options: [
         {
-          definedTags: [
-            'template',
-          ],
           typed: true,
         },
       ],