fix(check-examples): include column delta preceding regex mtch when regex has no groups

testing: bump mocha timeout to 5000ms (one test needs to retrieve a file)
testing(check-examples): increase coverage (`matchingFileName` and regex with no groups)

Author: brettz9

package.json

@@ -64,8 +64,8 @@
     "build": "rm -fr ./dist && NODE_ENV=production babel ./src --out-dir ./dist --copy-files --source-maps",
     "create-readme": "gitdown ./.README/README.md --output-file ./README.md && npm run add-assertions",
     "lint": "eslint ./src ./test",
-    "test-cov": "BABEL_ENV=test nyc mocha --recursive --require @babel/register --reporter progress",
-    "test": "BABEL_ENV=test nyc --reporter text-summary mocha --recursive --require @babel/register --reporter progress"
+    "test-cov": "BABEL_ENV=test nyc mocha --recursive --require @babel/register --reporter progress --timeout 5000",
+    "test": "BABEL_ENV=test nyc --reporter text-summary mocha --recursive --require @babel/register --reporter progress --timeout 5000"
   },
   "nyc": {
     "require": [

src/rules/checkExamples.js

@@ -108,14 +108,17 @@ export default iterateJsdoc(({
       source = source.slice(idx);
 
       source = source.replace(exampleCodeRegex, (n0, n1) => {
-        if (!n1) {
-          return n0;
+        let nonJSPreface;
+        let nonJSPrefaceLineCount;
+        if (n1) {
+          const index = n0.indexOf(n1);
+          nonJSPreface = n0.slice(0, index);
+          nonJSPrefaceLineCount = countChars(nonJSPreface, '\n');
+        } else {
+          nonJSPreface = '';
+          nonJSPrefaceLineCount = 0;
         }
 
-        const index = n0.indexOf(n1);
-        const nonJSPreface = n0.slice(0, index);
-        const nonJSPrefaceLineCount = countChars(nonJSPreface, '\n');
-
         nonJSPrefacingLines += nonJSPrefaceLineCount;
 
         // Ignore `preMatch` delta if newlines here
@@ -127,7 +130,7 @@ export default iterateJsdoc(({
           nonJSPrefacingCols += colDelta + nonJSPreface.length;
         }
 
-        return n1;
+        return n1 || n0;
       });
     }
 

test/rules/assertions/checkExamples.js

@@ -297,6 +297,55 @@ export default {
           noDefaultExampleRules: true
         }
       }
+    },
+    {
+      code: `
+          /**
+           * @example quux2()
+           */
+          function quux2 () {
+
+          }
+      `,
+      errors: [
+        {
+          message: '@example error (semi): Missing semicolon.'
+        }
+      ],
+      settings: {
+        jsdoc: {
+          matchingFileName: 'test/jsdocUtils.js'
+        }
+      }
+    },
+    {
+      code: `
+          /**
+           * @example // begin
+           alert('hello')
+           // end
+           */
+          function quux () {
+
+          }
+      `,
+      errors: [
+        {
+          message: '@example warning (semi): Missing semicolon.'
+        }
+      ],
+      settings: {
+        jsdoc: {
+          baseConfig: {
+            rules: {
+              semi: ['warn', 'always']
+            }
+          },
+          eslintrcForExamples: false,
+          exampleCodeRegex: '// begin[\\s\\S]*// end',
+          noDefaultExampleRules: true
+        }
+      }
     }
   ],
   valid: [