feat(check-types, no-undefined-types): report error if settings.jsdoc.preferredTypes item is not falsy/string/object

testing: add more coverage suggested tests

Author: brettz9

src/rules/checkTypes.js

@@ -152,6 +152,14 @@ export default iterateJsdoc(({
             preferred,
             _.get(preferredSetting, 'message')
           ]);
+        } else {
+          report(
+            'Invalid `settings.jsdoc.preferredTypes`. Values must be falsy, a string, or an object.',
+            null,
+            jsdocTag
+          );
+
+          return;
         }
       } else if (!noDefaults && type === 'NAME') {
         for (const strictNativeType of strictNativeTypes) {

src/rules/noUndefinedTypes.js

@@ -36,9 +36,14 @@ export default iterateJsdoc(({
           // May become an empty string but will be filtered out below
           return stripPseudoTypes(preferredType);
         }
-        if (!preferredType || typeof preferredType !== 'object') {
+        if (!preferredType) {
           return undefined;
         }
+        if (typeof preferredType !== 'object') {
+          report(
+            'Invalid `settings.jsdoc.preferredTypes`. Values must be falsy, a string, or an object.'
+          );
+        }
 
         return stripPseudoTypes(preferredType.replacement);
       }).filter((preferredType) => {

test/rules/assertions/checkTypes.js

@@ -1,5 +1,27 @@
 export default {
   invalid: [
+    {
+      code: `
+          /**
+           * @param {abc} foo
+           */
+          function quux (foo) {
+
+          }
+      `,
+      errors: [
+        {
+          message: 'Invalid `settings.jsdoc.preferredTypes`. Values must be falsy, a string, or an object.'
+        }
+      ],
+      settings: {
+        jsdoc: {
+          preferredTypes: {
+            abc: 100
+          }
+        }
+      }
+    },
     {
       code: `
           /**

test/rules/assertions/noUndefinedTypes.js

@@ -1,5 +1,58 @@
 export default {
   invalid: [
+    {
+      code: `
+        /**
+         * @param {HerType} baz - Foo.
+         */
+       function quux(foo, bar, baz) {
+
+       }
+      `,
+      errors: [
+        {
+          message: 'Invalid `settings.jsdoc.preferredTypes`. Values must be falsy, a string, or an object.'
+        },
+        {
+          message: 'The type \'HerType\' is undefined.'
+        }
+      ],
+      options: [{
+        preferredTypesDefined: true
+      }],
+      settings: {
+        jsdoc: {
+          preferredTypes: {
+            HerType: 1000
+          }
+        }
+      }
+    },
+    {
+      code: `
+        /**
+         * @param {HerType} baz - Foo.
+         */
+       function quux(foo, bar, baz) {
+
+       }
+      `,
+      errors: [
+        {
+          message: 'The type \'HerType\' is undefined.'
+        }
+      ],
+      options: [{
+        preferredTypesDefined: true
+      }],
+      settings: {
+        jsdoc: {
+          preferredTypes: {
+            HerType: false
+          }
+        }
+      }
+    },
     {
       code: `
           /**
@@ -261,6 +314,20 @@ export default {
       }
       `
     },
+    {
+      code: `
+      /**
+       *
+       *
+       */
+      function foo () {
+
+      }
+      `,
+      options: [{
+        preferredTypesDefined: true
+      }]
+    },
     {
       code: `
         /**

test/rules/assertions/requireParam.js

@@ -588,6 +588,21 @@ export default {
           exemptedBy: ['type']
         }
       ]
+    },
+    {
+      code: `
+          /**
+           * @override
+           */
+          var A = class {
+            /**
+              *
+              */
+            quux (foo) {
+
+            }
+          }
+      `
     }
   ]
 };