[self-host] fix dashboard and generate_key env vars (#33870)

1. fix the mixed up `./generate_key` arguments
2. `NEXT_PUBLIC_ADMIN_KEY` is unused, so remove it
3. `NEXT_PUBLIC_DEPLOYMENT_URL` is baked in at nextjs build-time, so we need to set it at build time, otherwise we get errors when ConvexReactClient tries to connect to url=undefined. I don't know how to fix this, but to unblock the build let's hard-code the value at build time to the default http://127.0.0.1:3210

GitOrigin-RevId: 80f1ff612eaa6cd2b76bdbb4ffd787ee21ccf058

Author: ldanilek

self-hosted/Dockerfile.dashboard

@@ -9,6 +9,9 @@ RUN git clone https://github.com/get-convex/convex-backend.git .
 WORKDIR /app/npm-packages/dashboard-self-hosted
 RUN npm install -g @microsoft/rush
 RUN rush update
+# NEXT_PUBLIC_DEPLOYMENT_URL is baked into the nextjs build
+# TODO: Make this configurable at runtime
+ENV NEXT_PUBLIC_DEPLOYMENT_URL="http://127.0.0.1:3210"
 RUN rush build -t dashboard-self-hosted
 
 EXPOSE 6791

self-hosted/docker-compose.yml

@@ -30,7 +30,6 @@ services:
       - "${DASHBOARD_PORT:-6791}:6791"
     environment:
       - NEXT_PUBLIC_DEPLOYMENT_URL=http://127.0.0.1:${PORT:-3210}
-      - NEXT_PUBLIC_ADMIN_KEY=${ADMIN_KEY}
     depends_on:
       backend:
         condition: service_healthy

self-hosted/generate_admin_key.sh

@@ -4,7 +4,7 @@ set -e
 
 source ./read_credentials.sh
 
-ADMIN_KEY=$(./generate_key "$INSTANCE_SECRET" "$INSTANCE_NAME")
+ADMIN_KEY=$(./generate_key "$INSTANCE_NAME" "$INSTANCE_SECRET")
 
 echo "$ADMIN_KEY"