Skip to content

Commit 45afe81

Browse files
goffrieConvex, Inc.
authored andcommitted
Escape literal strings when displaying schemas (#34998)
GitOrigin-RevId: a7e997e62c729e2807bdb7075fd249cd5188981d
1 parent b68f9d4 commit 45afe81

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

npm-packages/dashboard-common/src/lib/__snapshots__/format.test.ts.snap

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ export default defineSchema({
4444
anyField: v.any(),
4545
literalBigint: v.literal(1n),
4646
literalNumber: v.literal(0),
47-
literalString: v.literal("hello world"),
47+
literalString: v.literal("hello world\\"'\\n"),
4848
literalBoolean: v.literal(true),
4949
union: v.union(v.string(), v.float64()),
5050
object: v.object({ a: v.optional(v.any()) }),

npm-packages/dashboard-common/src/lib/format.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -345,7 +345,7 @@ describe("displaySchemaFromShapes", () => {
345345
literalString: {
346346
fieldType: {
347347
type: "literal",
348-
value: "hello world",
348+
value: "hello world\"'\n",
349349
},
350350
optional: false,
351351
},

npm-packages/dashboard-common/src/lib/format.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -198,7 +198,7 @@ function displayValidator(validator: ValidatorJSON): string {
198198
case "literal":
199199
switch (typeof validator.value) {
200200
case "string":
201-
return `v.literal("${validator.value}")`;
201+
return `v.literal(${JSON.stringify(validator.value)})`;
202202
case "number":
203203
return `v.literal(${validator.value})`;
204204
case "boolean":

0 commit comments

Comments
 (0)