remove _modules.latest_version field (#27130)

the `latest_version` field is unused now. and it's optional when parsed, so we can delete it.

note the module cache is keyed on source package id now.

also while we're here, there's a 3 year old TODO which i checked in db-verifier is already done.

GitOrigin-RevId: 79a59bab837dc91f3cbda95a0acad7470eff4825

Author: ldanilek

crates/model/src/modules/mod.rs

@@ -58,7 +58,6 @@ use self::{
         AnalyzedFunction,
         AnalyzedModule,
         ModuleSource,
-        ModuleVersion,
         ModuleVersionMetadata,
         SourceMap,
     },
@@ -365,15 +364,11 @@ impl<'a, RT: Runtime> ModuleModel<'a, RT> {
         analyze_result: Option<AnalyzedModule>,
         environment: ModuleEnvironment,
         sha256: Sha256Digest,
-    ) -> anyhow::Result<(ResolvedDocumentId, Option<ModuleVersion>)> {
-        let (module_id, version) = match self.module_metadata(path.clone()).await? {
+    ) -> anyhow::Result<ResolvedDocumentId> {
+        let module_id = match self.module_metadata(path.clone()).await? {
             Some(module_metadata) => {
-                let previous_version = module_metadata.latest_version;
-
-                let latest_version = previous_version.map(|v| v + 1);
                 let new_metadata = ModuleMetadata {
                     path: path.module_path,
-                    latest_version,
                     source_package_id,
                     environment,
                     analyze_result: analyze_result.clone(),
@@ -383,26 +378,23 @@ impl<'a, RT: Runtime> ModuleModel<'a, RT> {
                     .replace(module_metadata.id(), new_metadata.try_into()?)
                     .await?;
 
-                (module_metadata.id(), latest_version)
+                module_metadata.id()
             },
             None => {
-                let version = Some(0);
                 let new_metadata = ModuleMetadata {
                     path: path.module_path,
-                    latest_version: version,
                     source_package_id,
                     environment,
                     analyze_result: analyze_result.clone(),
                     sha256,
                 };
 
-                let document_id = SystemMetadataModel::new(self.tx, path.component.into())
+                SystemMetadataModel::new(self.tx, path.component.into())
                     .insert(&MODULES_TABLE, new_metadata.try_into()?)
-                    .await?;
-                (document_id, version)
+                    .await?
             },
         };
-        Ok((module_id, version))
+        Ok(module_id)
     }
 
     /// Delete a module, making it inaccessible for subsequent transactions.

crates/model/src/modules/types.rs

@@ -15,7 +15,6 @@ use value::{
 
 use super::module_versions::{
     AnalyzedModule,
-    ModuleVersion,
     SerializedAnalyzedModule,
 };
 use crate::source_packages::types::SourcePackageId;
@@ -26,8 +25,6 @@ use crate::source_packages::types::SourcePackageId;
 pub struct ModuleMetadata {
     /// Path stored as a "path" field.
     pub path: CanonicalizedModulePath,
-    /// What is the latest version of the module?
-    pub latest_version: Option<ModuleVersion>,
 
     pub source_package_id: SourcePackageId,
     pub environment: ModuleEnvironment,
@@ -40,7 +37,6 @@ pub struct ModuleMetadata {
 #[serde(rename_all = "camelCase")]
 pub struct SerializedModuleMetadata {
     pub path: String,
-    pub latest_version: Option<ModuleVersion>,
     pub source_package_id: String,
     pub environment: String,
     pub analyze_result: Option<SerializedAnalyzedModule>,
@@ -54,11 +50,8 @@ impl TryFrom<SerializedModuleMetadata> for ModuleMetadata {
         Ok(Self {
             path: {
                 let path: ModulePath = m.path.parse()?;
-                // TODO: Remove this canonicalization once we've fully backfilled canonicalized
-                // module paths.
-                path.canonicalize()
+                path.assume_canonicalized()?
             },
-            latest_version: m.latest_version,
             source_package_id: DeveloperDocumentId::decode(&m.source_package_id)?.into(),
             environment: m.environment.parse()?,
             analyze_result: m.analyze_result.map(|s| s.try_into()).transpose()?,
@@ -73,7 +66,6 @@ impl TryFrom<ModuleMetadata> for SerializedModuleMetadata {
     fn try_from(m: ModuleMetadata) -> anyhow::Result<Self> {
         Ok(Self {
             path: String::from(m.path),
-            latest_version: m.latest_version,
             source_package_id: DeveloperDocumentId::from(m.source_package_id).to_string(),
             environment: m.environment.to_string(),
             analyze_result: m.analyze_result.map(|s| s.try_into()).transpose()?,