Skip to content

Commit 7e87abb

Browse files
Sujay JayakarConvex, Inc.
Sujay Jayakar
authored and
Convex, Inc.
committed
Spell "committer" with two Ts in our codebase (#27151)
I'll duplicate all the existing knobs in production to have both one and two Ts before landing this. GitOrigin-RevId: 7e6a8d502e076dff4f400281ef080d99b3d09bf9
1 parent 795d257 commit 7e87abb

File tree

3 files changed

+12
-12
lines changed

3 files changed

+12
-12
lines changed

crates/common/src/knobs.rs

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -575,14 +575,14 @@ pub static DATABASE_UDF_SYSTEM_TIMEOUT: LazyLock<Duration> =
575575
pub static ISOLATE_QUEUE_SIZE: LazyLock<usize> =
576576
LazyLock::new(|| env_config("ISOLATE_QUEUE_SIZE", 2000));
577577

578-
/// The size of the pending commits in the commiter queue. This is a FIFO queue,
579-
/// so if the queue is too large, we run into a risk of all requests waiting too
580-
/// long and no requests going through during overload. The size of each commit
581-
/// request is also typically larger than a isolate request. For time being,
582-
/// allow 128 slots, which is the maximum number of isolate threads in
583-
/// any process.
584-
pub static COMMITER_QUEUE_SIZE: LazyLock<usize> =
585-
LazyLock::new(|| env_config("COMMITER_QUEUE_SIZE", 128));
578+
/// The size of the pending commits in the committer queue. This is a FIFO
579+
/// queue, so if the queue is too large, we run into a risk of all requests
580+
/// waiting too long and no requests going through during overload. The size of
581+
/// each commit request is also typically larger than a isolate request. For
582+
/// time being, allow 128 slots, which is the maximum number of isolate threads
583+
/// in any process.
584+
pub static COMMITTER_QUEUE_SIZE: LazyLock<usize> =
585+
LazyLock::new(|| env_config("COMMITTER_QUEUE_SIZE", 128));
586586

587587
/// 0 -> default (number of cores)
588588
pub static V8_THREADS: LazyLock<u32> = LazyLock::new(|| env_config("V8_THREADS", 0));

crates/database/src/committer.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ use common::{
2222
},
2323
errors::recapture_stacktrace,
2424
knobs::{
25-
COMMITER_QUEUE_SIZE,
25+
COMMITTER_QUEUE_SIZE,
2626
MAX_REPEATABLE_TIMESTAMP_COMMIT_DELAY,
2727
MAX_REPEATABLE_TIMESTAMP_IDLE_FREQUENCY,
2828
},
@@ -174,7 +174,7 @@ impl<RT: Runtime> Committer<RT> {
174174
) -> CommitterClient<RT> {
175175
let persistence_reader = persistence.reader();
176176
let conflict_checker = PendingWrites::new(persistence_reader.version());
177-
let (tx, rx) = mpsc::channel(*COMMITER_QUEUE_SIZE);
177+
let (tx, rx) = mpsc::channel(*COMMITTER_QUEUE_SIZE);
178178
let snapshot_reader = snapshot_manager.reader();
179179
let committer = Self {
180180
pending_writes: conflict_checker,

crates/usage_tracking/src/lib.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -519,9 +519,9 @@ impl StorageUsageTracker for UsageCounter {
519519
#[derive(Debug, Clone)]
520520
pub struct FunctionUsageTracker {
521521
// TODO: We should ideally not use an Arc<Mutex> here. The best way to achieve
522-
// this is to move the logic for accounting ingress out of the Commiter into
522+
// this is to move the logic for accounting ingress out of the Committer into
523523
// the Transaction. Then Transaction can solely own the counters and we can
524-
// remove clone(). The alternative is for the Commiter to take ownership of
524+
// remove clone(). The alternative is for the Committer to take ownership of
525525
// the usage tracker and then return it, but this will make it complicated if
526526
// we later decide to charge people for OCC bandwidth.
527527
state: Arc<Mutex<FunctionUsageStats>>,

0 commit comments

Comments
 (0)