Skip to content

Commit 2ca2f01

Browse files
committed
ref(v9): Remove v9 todos
1 parent bbfc903 commit 2ca2f01

File tree

4 files changed

+9
-30
lines changed

4 files changed

+9
-30
lines changed

docs/platforms/javascript/guides/electron/configuration/integrations/mainprocesssession.mdx

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,16 +12,15 @@ use the <PlatformLink
1212
to="/configuration/integrations/browserwindowsession">BrowserWindowSession</PlatformLink>
1313
integration in the renderer processes.
1414

15-
{/* TODO(v9): When electron does a new major, update this since autoSessionTracking got removed */}
16-
17-
Unless `autoSessionTracking` is set to `false`, this integration will be automatically added.
15+
To disable sending sessions, remove the `MainProcessSession` integration:
1816

1917
```javascript
2018
import * as Sentry from "@sentry/electron/main";
2119

2220
Sentry.init({
2321
dsn: "___PUBLIC_DSN___",
24-
autoSessionTracking: false,
22+
integrations: (defaults) =>
23+
defaults.filter((i) => i.name !== "MainProcessSession"),
2524
});
2625
```
2726

platform-includes/configuration/auto-session-tracking/javascript.electron.mdx

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,14 @@ Due to the nature of `crashed` and `abnormal` exits, these sessions are finished
1010

1111
To receive data on user adoption, such as users crash free rate percentage, and the number of users that have adopted a specific release, set the user on the [`initialScope`](/platforms/javascript/configuration/options/#initial-scope) when initializing the SDK.
1212

13-
{/* TODO(v9): When electron does a new major, update this since autoSessionTracking got removed */}
14-
15-
To disable sending sessions, set the `autoSessionTracking` flag to `false`:
13+
To disable sending sessions, remove the `MainProcessSession` integration:
1614

1715
```javascript
16+
import * as Sentry from "@sentry/electron/main";
17+
1818
Sentry.init({
19-
autoSessionTracking: false, // default: true
19+
dsn: "___PUBLIC_DSN___",
20+
integrations: (defaults) =>
21+
defaults.filter((i) => i.name !== "MainProcessSession"),
2022
});
2123
```

platform-includes/configuration/auto-session-tracking/javascript.node.mdx

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -14,17 +14,3 @@ Sentry.init({
1414
autoSessionTracking: false, // default: true
1515
});
1616
```
17-
18-
{/* TODO(v9): Remove this notice? */}
19-
20-
<PlatformSection notSupported={["javacript.cordova", "javascript.capacitor", "javascript.electron"]}>
21-
22-
<Alert title="Deprecation Notice">
23-
24-
{/* We don't use platform links here because we always have to link to node and browser here and doing a conditional just for that feels overkill. */}
25-
26-
Starting with SDK version 8.43.0 and up, the `autoSessionTracking` option has been deprecated. You can use the [BrowserSession integration](/platforms/javascript/configuration/integrations/browsersession/) in browser environments and the [Http integration](/platforms/javascript/guides/node/configuration/integrations/http/) (via the `trackIncomingRequestsAsSessions` option) in Node.js runtime.
27-
28-
</Alert>
29-
30-
</PlatformSection>

platform-includes/getting-started-use/javascript.nestjs.mdx

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -52,9 +52,6 @@ export class YourCatchAllExceptionFilter implements ExceptionFilter {
5252
By default, only unhandled exceptions that are not caught by an error filter are reported to Sentry.
5353
`HttpException`s (including [derivatives](https://docs.nestjs.com/exception-filters#built-in-http-exceptions)) are also not captured by default because they mostly act as control flow vehicles.
5454

55-
{/* TODO(v9): Remove this note */}
56-
_Note that `@SentryExceptionCaptured()` was called `@WithSentry` in SDK versions `8.38.0` and prior._
57-
5855
If you don't have a global catch-all exception filter, add the `SentryGlobalFilter` to the providers of your main module.
5956
This filter will report any unhandled errors that aren't caught by other error filters to Sentry.
6057
**Important:** The `SentryGlobalFilter` needs to be registered before any other exception filters.
@@ -76,11 +73,6 @@ import { SentryGlobalFilter } from "@sentry/nestjs/setup";
7673
export class AppModule {}
7774
```
7875

79-
{/* TODO(v9): Remove this note. */}
80-
81-
**Note:** If you have a NestJS + GraphQL application and you are using the `@sentry/nestjs` SDK version `8.38.0` or earlier, replace the `SentryGlobalFilter` with the `SentryGlobalGenericFilter`.
82-
In SDK versions `8.39.0` and above, the `SentryGlobalGenericFilter` is deprecated because the `SentryGlobalFilter` will handle GraphQL contexts automatically.
83-
8476
If you have error filters for specific types of exceptions (for example `@Catch(HttpException)`, or any other `@Catch(...)` with arguments) and you want to capture errors caught by these filters, capture the errors in the `catch()` handler with `Sentry.captureException()`:
8577

8678
```javascript {9}

0 commit comments

Comments
 (0)