Skip to content

Commit 34cc268

Browse files
authored
Remove explicit rewrite flags from sentry cli RN (#5179)
1 parent 144e18b commit 34cc268

File tree

2 files changed

+9
-3
lines changed

2 files changed

+9
-3
lines changed

src/docs/clients/react-native/sourcemaps.mdx

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ This SDK has been superseded by the new React Native SDK. Sentry preserves this
1515

1616
Currently automatic source map handling is only implemented for iOS with Xcode and Android with gradle. If you manually invoke the [react-native packager](https://github.com/facebook/metro) you can however get source maps anyways by passing _–sourcemap-output_ to it.
1717

18-
If you do get source maps, you can upload them with `sentry-cli`. Before _v1.59.0_, please ensure passing `--rewrite` to the `upload-sourcemaps` command which will fix up the source maps before the upload (inlines sources etc.). As of _1.59.0_, this is done automatically.
18+
If you do get source maps, you can upload them with `sentry-cli`.
1919

2020
Example:
2121

@@ -40,6 +40,12 @@ node_modules/@sentry/cli/bin/sentry-cli releases \
4040
/path/to/your/files
4141
```
4242

43+
<Note>
44+
45+
If you're using `sentry-cli` prior to version 1.59.0, pass `--rewrite` to the `upload-sourcemaps` command to fix up the source maps before the upload (inlines sources and so forth). Version 1.59.0 does this automatically.
46+
47+
</Note>
48+
4349
The values for `RELEASE_NAME` and `DISTRIBUTION_NAME` are as follows:
4450

4551
`RELEASE_NAME`:

src/platforms/react-native/sourcemaps.mdx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ node_modules/@sentry/cli/bin/sentry-cli releases \
9999
upload-sourcemaps \
100100
--dist <dist> \
101101
--strip-prefix /path/to/project/root \
102-
--rewrite index.android.bundle index.android.bundle.map
102+
index.android.bundle index.android.bundle.map
103103
```
104104

105105
```bash {tabTitle:iOS}
@@ -108,7 +108,7 @@ node_modules/@sentry/cli/bin/sentry-cli releases \
108108
upload-sourcemaps \
109109
--dist <dist> \
110110
--strip-prefix /path/to/project/root \
111-
--rewrite main.jsbundle main.jsbundle.map
111+
main.jsbundle main.jsbundle.map
112112
```
113113

114114
<Note>

0 commit comments

Comments
 (0)