Skip to content

Commit 36598df

Browse files
wmakPeloWriter
andauthored
fix: Add connecting services to node + express (#3418)
- Also Adding a line about how exceeding the span limit can result in broken subtraces Co-authored-by: Fiona <[email protected]>
1 parent 85cabf0 commit 36598df

File tree

5 files changed

+25
-8
lines changed

5 files changed

+25
-8
lines changed

src/docs/product/performance/trace-view.mdx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ Broken subtraces may be caused by:
4141
- [Ad blockers](/platforms/javascript/troubleshooting/#dealing-with-ad-blockers) may prevent transactions in browsers being sent, but HTTP requests to backend projects will still create child transactions
4242
- [Rate-limiting](/product/accounts/quotas/#limiting-events) on a project may cause only some events to be sent to Sentry
4343
- [Project permissions](/product/accounts/membership/#restricting-access) may mean you do not have access to transactions in another project
44+
- Exceeding the span limit. Transactions are associated via the child spans of the parent transaction, but if the number of spans exceed the limit, the association cannot be made
4445

4546
### Multiple Roots
4647

src/platforms/common/performance/index.mdx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -91,11 +91,11 @@ Leaving the sample rate at `1.0` means that included instrumentation will send a
9191

9292
## Connecting Services
9393

94-
If you are also using Performance Monitoring for [JavaScript](/platforms/javascript/performance/) depending on where your request originates there are two methods to connect your traces:
95-
1. For requests that start in your backend, this is done by [adding a meta tag](/platforms/javascript/performance/connect-services/#pageload) in your HTML template that contains tracing information.
96-
2. For requests that start in JavaScript, this is done by the SDK [setting a header](/platforms/javascript/performance/connect-services/#navigation-and-other-xhr-requests) on requests to your backend.
94+
If you are also using Performance Monitoring for [JavaScript](/platforms/javascript/performance/), depending on where your request originates, you can connect traces:
95+
1. For requests that start in your backend, by [adding a meta tag](/platforms/javascript/performance/connect-services/#pageload) in your HTML template that contains tracing information.
96+
2. For requests that start in JavaScript, by the SDK [setting a header](/platforms/javascript/performance/connect-services/#navigation-and-other-xhr-requests) on requests to your backend.
9797

98-
Otherwise backend services with Performance Monitoring will connect automatically.
98+
Otherwise, backend services with Performance Monitoring connect automatically.
9999

100100
</PlatformSection>
101101

src/platforms/node/common/performance/index.mdx

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -99,3 +99,11 @@ app.get("/success", function successHandler(req, res) {
9999
res.status(200).end();
100100
});
101101
```
102+
103+
## Connecting Services
104+
105+
If you are also using Performance Monitoring for [JavaScript](/platforms/javascript/performance/), depending on where your request originates, you can connect traces:
106+
1. For requests that start in your backend, by [adding a meta tag](/platforms/javascript/performance/connect-services/#pageload) in your HTML template that contains tracing information.
107+
2. For requests that start in JavaScript, by the SDK [setting a header](/platforms/javascript/performance/connect-services/#navigation-and-other-xhr-requests) on requests to your backend.
108+
109+
Otherwise, backend services with Performance Monitoring connect automatically.

src/platforms/node/guides/express/performance/index.mdx

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -100,3 +100,11 @@ app.get("/success", function successHandler(req, res) {
100100
res.status(200).end();
101101
});
102102
```
103+
104+
## Connecting Services
105+
106+
If you are also using Performance Monitoring for [JavaScript](/platforms/javascript/performance/), depending on where your request originates, you can connect traces:
107+
1. For requests that start in your backend, by [adding a meta tag](/platforms/javascript/performance/connect-services/#pageload) in your HTML template that contains tracing information.
108+
2. For requests that start in JavaScript, by the SDK [setting a header](/platforms/javascript/performance/connect-services/#navigation-and-other-xhr-requests) on requests to your backend.
109+
110+
Otherwise, backend services with Performance Monitoring connect automatically.

src/platforms/php/common/performance.mdx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -116,11 +116,11 @@ After you set up Relay, you should see a dramatic improvement to the impact on y
116116

117117
<PlatformSection notSupported={["php.laravel"]}>
118118

119-
If you are also using Performance Monitoring for [JavaScript](/platforms/javascript/performance/) depending on where your request originates there are two methods to connect your traces:
120-
1. For requests that start in your backend, this is done by [adding a meta tag](/platforms/javascript/performance/connect-services/#pageload) in your HTML template that contains tracing information.
121-
2. For requests that start in JavaScript, this is done by the SDK [setting a header](/platforms/javascript/performance/connect-services/#navigation-and-other-xhr-requests) on requests to your backend.
119+
If you are also using Performance Monitoring for [JavaScript](/platforms/javascript/performance/), depending on where your request originates, you can connect traces:
120+
1. For requests that start in your backend, by [adding a meta tag](/platforms/javascript/performance/connect-services/#pageload) in your HTML template that contains tracing information.
121+
2. For requests that start in JavaScript, by the SDK [setting a header](/platforms/javascript/performance/connect-services/#navigation-and-other-xhr-requests) on requests to your backend.
122122

123-
Otherwise backend services with Performance Monitoring will connect automatically.
123+
Otherwise, backend services with Performance Monitoring connect automatically.
124124

125125
</PlatformSection>
126126

0 commit comments

Comments
 (0)