Skip to content

feat: New Ember docs #2124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 39 commits into from
Oct 8, 2020
Merged

feat: New Ember docs #2124

merged 39 commits into from
Oct 8, 2020

Conversation

k-fish
Copy link
Member

@k-fish k-fish commented Aug 28, 2020

This updates the documentation to point at the new Ember addon.

@k-fish
feat: New Ember docs
ec9b836 
This updates the documentation to point at the new Ember addon
@k-fish k-fish requested a review from a team as a code owner August 28, 2020 19:17
@vercel
Copy link

vercel bot commented Aug 28, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sentry/sentry-docs/n0msafdpu/sentry.dev
✅ Preview: https://sentry-docs-git-feat-new-ember-docs.sentry.dev

PeloWriter
PeloWriter approved these changes Aug 28, 2020
View reviewed changes
Copy link
Contributor

@PeloWriter PeloWriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start here, Kevan. Thanks for adopting the template language. LMK if you have questions - I'll take a second look after the performance updates.

@rhcarvalho
Copy link
Contributor

Great to have Ember docs, let's get this in :)

@k-fish
Copy link
Member Author

k-fish commented Sep 3, 2020

Talked to Fiona about this, it'll be in soon, probably beginning of next week, waiting on getsentry/sentry-javascript#2784

@vercel vercel bot temporarily deployed to Preview September 8, 2020 19:07 Inactive
@vercel vercel bot temporarily deployed to Preview September 8, 2020 19:07 Inactive
@vercel vercel bot temporarily deployed to Preview September 8, 2020 19:07 Inactive
@vercel vercel bot temporarily deployed to Preview September 8, 2020 19:08 Inactive
@k-fish
Copy link
Member Author

k-fish commented Sep 15, 2020

Currently waiting on getsentry/sentry-javascript#2902

PeloWriter
PeloWriter reviewed Sep 15, 2020
View reviewed changes
Copy link
Contributor

@PeloWriter PeloWriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@PeloWriter PeloWriter mentioned this pull request Sep 16, 2020
Closed
PeloWriter
PeloWriter approved these changes Oct 8, 2020
View reviewed changes
Copy link
Contributor

@PeloWriter PeloWriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@k-fish k-fish merged commit 5ca28f8 into master Oct 8, 2020
@k-fish k-fish deleted the feat/new-ember-docs branch October 8, 2020 21:55
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@PeloWriter PeloWriter PeloWriter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@k-fish @rhcarvalho @PeloWriter