feat: Move SDK perfromance docs to platforms #2175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sentry/sentry-docs/roiqpn38q/sentry.dev |
PeloWriter
approved these changes
Sep 3, 2020
| Next, initialize the integration in your call to `Sentry.init`: | ||
|
|
||
| ```js | ||
| ```javascript {tabTitle: CDN} |
There was a problem hiding this comment.
In this PR (#2160) , the CDN pieces moved into their own page (https://docs.sentry.io/platforms/javascript/configuration/install-cdn) based on feedback on the JS Getting Started content.
| @@ -296,3 +288,8 @@ span.setData("parameters", parameters); | |||
| span.setData("user_id", parameters.user_id); | |||
| http.get(`${base_url}/${endpoint}/`, (data = parameters)); | |||
| ``` | |||
|
|
|||
There was a problem hiding this comment.
We've removed the Next Steps links that are hand managed in the SDK content - the goal will be to replace them with something that's auto-generated.
HazAT
force-pushed
the
feat/js-performance
branch
from
23fcdc1 to
6e91a27
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This basically moves the performance Getting started into SDK platforms.
Supersedes:
#2121
#2133