Skip to content

fix: Link to DSN config option #2199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 8, 2020
Merged

fix: Link to DSN config option #2199

merged 1 commit into from
Sep 8, 2020

Conversation

joergi
Copy link
Contributor

@joergi joergi commented Sep 4, 2020

the original link was only a 404, this should fix it
@vercel
Copy link

vercel bot commented Sep 4, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sentry/sentry-docs/8slh22fu7/sentry.dev
✅ Preview: https://sentry-docs-git-fork-joergi-patch-1.sentry.dev

@rhcarvalho rhcarvalho changed the title fixing the link to the DNS Readme fix: Link to DSN config option Sep 8, 2020
@rhcarvalho rhcarvalho merged commit c839c8a into getsentry:master Sep 8, 2020
@rhcarvalho
Copy link
Contributor

Thanks @joergi

@rhcarvalho rhcarvalho mentioned this pull request Sep 8, 2020
ajjindal pushed a commit that referenced this pull request Sep 9, 2020
@joergi
Copy link
Contributor Author

joergi commented Sep 9, 2020

@rhcarvalho - I have seen a similar error somewhere else...
is the old way of linking to it somewhere still available?
or was there a complete change to the new one?

so was everything changed from
config/#....
to
configuration/options/#....
?

Or are there still some valid links for config/#.... ?

@rhcarvalho
Copy link
Contributor

@joergi there was a big change recently, sorry for the disruption and thanks for reporting. I went ahead and fixed links following that pattern. Yesterday we added a link checker to CI and should be fixing the rest of the broken links in the next days.

@joergi joergi deleted the patch-1 branch September 9, 2020 12:06
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants