Skip to content

feat(getting-started): Switch from manual setup to sentry-wizard for Android and iOS in getting started #7767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 34 commits into from
Sep 12, 2023
Merged

feat(getting-started): Switch from manual setup to sentry-wizard for Android and iOS in getting started #7767

merged 34 commits into from
Sep 12, 2023

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented Sep 7, 2023 •
edited
Loading

Pre-merge checklist

If you work at Sentry, you're able to merge your own PR without review, but please don't unless there's a good reason.

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs
  • PR was reviewed and approved by a member of the Sentry docs team

Description of changes

  • Switches from manual setup to sentry-wizard for Android and iOS in getting started
    • For apple I had to split this for ios and non-ios since the wizard supports only iOS I think? Let me know if I should change it for all apple targets
  • Introduces new "Manual Setup" top-level section to be redirected to the old getting started docs

Part of getsentry/sentry-java#2877 and getsentry/sentry-cocoa#3198

@romtsn romtsn requested a review from smeubank September 7, 2023 14:35
@romtsn romtsn requested a review from a team as a code owner September 7, 2023 14:35
@vercel
Copy link

vercel bot commented Sep 7, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 8, 2023 8:37am

@romtsn romtsn mentioned this pull request Sep 7, 2023
Merged
brustolin
brustolin approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@brustolin brustolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

lizokm
lizokm approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@lizokm lizokm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor language suggestions, but this looks good!

lizokm
lizokm approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@lizokm lizokm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few more tiny tweaks :)

romtsn and others added 19 commits September 8, 2023 10:13
@romtsn @lizokm
Update src/platform-includes/getting-started-config/android.mdx
e5826b6 
Co-authored-by: Liza Mock <[email protected]>
@romtsn @lizokm
Update src/platform-includes/getting-started-config/apple.ios.mdx
7d229c5 
Co-authored-by: Liza Mock <[email protected]>
@romtsn @lizokm
Update src/platform-includes/getting-started-config/apple.ios.mdx
eb5533f 
Co-authored-by: Liza Mock <[email protected]>
@romtsn @lizokm
Update src/platform-includes/getting-started-config/apple.ios.mdx
eeda377 
Co-authored-by: Liza Mock <[email protected]>
@romtsn @lizokm
Update src/platform-includes/getting-started-config/apple.ios.mdx
2e15b6f 
Co-authored-by: Liza Mock <[email protected]>
@romtsn @lizokm
Update src/platform-includes/getting-started-install/android.mdx
2458e90 
Co-authored-by: Liza Mock <[email protected]>
@romtsn @lizokm
Update src/platform-includes/getting-started-install/android.mdx
8a25318 
Co-authored-by: Liza Mock <[email protected]>
@romtsn @lizokm
Update src/platform-includes/getting-started-install/apple.ios.mdx
19ff53c 
Co-authored-by: Liza Mock <[email protected]>
@getsantry
style(lint): Auto commit lint changes
79bb51f
@getsantry
style(lint): Auto commit lint changes
8358404
@romtsn @lizokm
Update src/platform-includes/getting-started-install/apple.ios.mdx
b02bd60 
Co-authored-by: Liza Mock <[email protected]>
@getsantry
style(lint): Auto commit lint changes
63b7d1d
@getsantry
style(lint): Auto commit lint changes
c806a36
@getsantry
style(lint): Auto commit lint changes
8a8888c
@romtsn @lizokm
Update src/platform-includes/getting-started-verify/android.mdx
9a728bf 
Co-authored-by: Liza Mock <[email protected]>
@romtsn @lizokm
Update src/platforms/android/manual-setup.mdx
0c84c25 
Co-authored-by: Liza Mock <[email protected]>
@getsantry
style(lint): Auto commit lint changes
60298c1
@getsantry
style(lint): Auto commit lint changes
761fb4f
@romtsn @lizokm
Update src/platforms/android/manual-setup.mdx
2af592f 
Co-authored-by: Liza Mock <[email protected]>
getsantry bot and others added 13 commits September 8, 2023 08:17
@getsantry
style(lint): Auto commit lint changes
ac9dbe2
@getsantry
style(lint): Auto commit lint changes
54fd4dc
@getsantry
style(lint): Auto commit lint changes
f056fde
@getsantry
style(lint): Auto commit lint changes
87820d8
@getsantry
style(lint): Auto commit lint changes
6619075
@getsantry
style(lint): Auto commit lint changes
543468a
@romtsn @lizokm
Update src/platforms/android/manual-setup.mdx
20f9339 
Co-authored-by: Liza Mock <[email protected]>
@romtsn @lizokm
Update src/platforms/apple/guides/ios/manual-setup.mdx
3503c08 
Co-authored-by: Liza Mock <[email protected]>
@romtsn @lizokm
Update src/platforms/apple/guides/ios/manual-setup.mdx
57063a8 
Co-authored-by: Liza Mock <[email protected]>
@romtsn @lizokm
Update src/platforms/apple/guides/ios/manual-setup.mdx
2301a72 
Co-authored-by: Liza Mock <[email protected]>
@romtsn @lizokm
Update src/platforms/android/manual-setup.mdx
de19756 
Co-authored-by: Liza Mock <[email protected]>
@romtsn @lizokm
Update src/platforms/apple/guides/ios/manual-setup.mdx
4fbff3f 
Co-authored-by: Liza Mock <[email protected]>
@romtsn
Remove async stacktraces section as it's already under experimental f…
789a526 
…eatures
@romtsn romtsn merged commit 2d45f6c into master Sep 12, 2023
@romtsn romtsn deleted the rz/feat/android-and-ios-wizard-getting-started branch September 12, 2023 12:58
@github-actions github-actions bot locked and limited conversation to collaborators Sep 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lizokm lizokm lizokm approved these changes

@brustolin brustolin brustolin approved these changes

@smeubank smeubank Awaiting requested review from smeubank

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@romtsn @lizokm @brustolin