Skip to content

feat(nextjs): Upgrade sentry to v8 #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions apps/nextjs-13_2_0/instrumentation.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
export async function register() {
if (process.env.NEXT_RUNTIME === 'nodejs') {
await import('./sentry.server.config');
}

if (process.env.NEXT_RUNTIME === 'edge') {
await import('./sentry.edge.config');
}
}
1 change: 1 addition & 0 deletions apps/nextjs-13_2_0/next.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ const { withSentryConfig } = require('@sentry/nextjs');
const nextConfig = {
experimental: {
appDir: true,
instrumentationHook: true,
},
};

Expand Down
2 changes: 1 addition & 1 deletion apps/nextjs-13_2_0/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"lint": "next lint"
},
"dependencies": {
"@sentry/nextjs": "7.110.1",
"@sentry/nextjs": "8.9.2",
"@types/node": "20.12.7",
"@types/react": "18.2.79",
"@types/react-dom": "18.2.25",
Expand Down
1,491 changes: 565 additions & 926 deletions payload-files/nextjs-13_2_0/_api_test-error--event.json

Large diffs are not rendered by default.

206 changes: 83 additions & 123 deletions payload-files/nextjs-13_2_0/_api_test-error--transaction.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,16 @@
"event_id": "[[ID1]]",
"sdk": {
"name": "sentry.javascript.nextjs",
"version": "7.110.1"
"version": "8.0.0-beta.1"
},
"sent_at": "[[ISODateString]]",
"trace": {
"environment": "qa",
"public_key": "[[publicKey]]",
"trace_id": "[[ID2]]"
"sample_rate": "1",
"sampled": "true",
"trace_id": "[[ID2]]",
"transaction": "GET /api/test-error/route"
}
},
{
Expand All @@ -21,46 +24,20 @@
{
"category": "console",
"level": "log",
"message": "\u001b[36mwait\u001b[39m - compiling /api/test-success/route (client and server)...",
"message": " \u001b[32m\u001b[1m✓\u001b[22m\u001b[39m Ready in 3.9s",
"timestamp": "[[timestamp]]"
},
{
"category": "console",
"level": "log",
"message": "\u001b[35mevent\u001b[39m - compiled client and server successfully in 255 ms (1321 modules)",
"level": "warning",
"message": " \u001b[33m\u001b[1m⚠\u001b[22m\u001b[39m ../../node_modules/@opentelemetry/instrumentation/build/esm/platform/node/instrumentation.js\nCritical dependency: the request of a dependency is an expression\n\nImport trace for requested module:\n../../node_modules/@opentelemetry/instrumentation/build/esm/platform/node/instrumentation.js\n../../node_modules/@opentelemetry/instrumentation/build/esm/platform/node/index.js\n../../node_modules/@opentelemetry/instrumentation/build/esm/platform/index.js\n../../node_modules/@opentelemetry/instrumentation/build/esm/index.js\n../../node_modules/@sentry/nextjs/node_modules/@sentry/node/cjs/index.js\n../../node_modules/@sentry/nextjs/cjs/index.server.js\n\n../../node_modules/@prisma/instrumentation/node_modules/@opentelemetry/instrumentation/build/esm/platform/node/instrumentation.js\nCritical dependency: the request of a dependency is an expression\n\nImport trace for requested module:\n../../node_modules/@prisma/instrumentation/node_modules/@opentelemetry/instrumentation/build/esm/platform/node/instrumentation.js\n../../node_modules/@prisma/instrumentation/node_modules/@opentelemetry/instrumentation/build/esm/platform/node/index.js\n../../node_modules/@prisma/instrumentation/node_modules/@opentelemetry/instrumentation/build/esm/platform/index.js\n../../node_modules/@prisma/instrumentation/node_modules/@opentelemetry/instrumentation/build/esm/index.js\n../../node_modules/@prisma/instrumentation/dist/chunk-L6V5ZEAH.js\n../../node_modules/@prisma/instrumentation/dist/index.js\n../../node_modules/@sentry/nextjs/node_modules/@sentry/node/cjs/index.js\n../../node_modules/@sentry/nextjs/cjs/index.server.js",
"timestamp": "[[timestamp]]"
},
{
"category": "console",
"level": "log",
"message": "\u001b[36mwait\u001b[39m - compiling /api/test-error/route (client and server)...",
"level": "warning",
"message": " \u001b[33m\u001b[1m⚠\u001b[22m\u001b[39m ../../node_modules/@opentelemetry/instrumentation/build/esm/platform/node/instrumentation.js\nCritical dependency: the request of a dependency is an expression\n\nImport trace for requested module:\n../../node_modules/@opentelemetry/instrumentation/build/esm/platform/node/instrumentation.js\n../../node_modules/@opentelemetry/instrumentation/build/esm/platform/node/index.js\n../../node_modules/@opentelemetry/instrumentation/build/esm/platform/index.js\n../../node_modules/@opentelemetry/instrumentation/build/esm/index.js\n../../node_modules/@sentry/nextjs/node_modules/@sentry/node/cjs/index.js\n../../node_modules/@sentry/nextjs/cjs/index.server.js\n\n../../node_modules/@prisma/instrumentation/node_modules/@opentelemetry/instrumentation/build/esm/platform/node/instrumentation.js\nCritical dependency: the request of a dependency is an expression\n\nImport trace for requested module:\n../../node_modules/@prisma/instrumentation/node_modules/@opentelemetry/instrumentation/build/esm/platform/node/instrumentation.js\n../../node_modules/@prisma/instrumentation/node_modules/@opentelemetry/instrumentation/build/esm/platform/node/index.js\n../../node_modules/@prisma/instrumentation/node_modules/@opentelemetry/instrumentation/build/esm/platform/index.js\n../../node_modules/@prisma/instrumentation/node_modules/@opentelemetry/instrumentation/build/esm/index.js\n../../node_modules/@prisma/instrumentation/dist/chunk-L6V5ZEAH.js\n../../node_modules/@prisma/instrumentation/dist/index.js\n../../node_modules/@sentry/nextjs/node_modules/@sentry/node/cjs/index.js\n../../node_modules/@sentry/nextjs/cjs/index.server.js\n\n../../node_modules/@opentelemetry/instrumentation/build/esm/platform/node/instrumentation.js\nCritical dependency: the request of a dependency is an expression\n\nImport trace for requested module:\n../../node_modules/@opentelemetry/instrumentation/build/esm/platform/node/instrumentation.js\n../../node_modules/@opentelemetry/instrumentation/build/esm/platform/node/index.js\n../../node_modules/@opentelemetry/instrumentation/build/esm/platform/index.js\n../../node_modules/@opentelemetry/instrumentation/build/esm/index.js\n../../node_modules/@sentry/nextjs/node_modules/@sentry/node/cjs/index.js\n../../node_modules/@sentry/nextjs/cjs/index.server.js\n./app/api/test-success/route.ts\n\n../../node_modules/@prisma/instrumentation/node_modules/@opentelemetry/instrumentation/build/esm/platform/node/instrumentation.js\nCritical dependency: the request of a dependency is an expression\n\nImport trace for requested module:\n../../node_modules/@prisma/instrumentation/node_modules/@opentelemetry/instrumentation/build/esm/platform/node/instrumentation.js\n../../node_modules/@prisma/instrumentation/node_modules/@opentelemetry/instrumentation/build/esm/platform/node/index.js\n../../node_modules/@prisma/instrumentation/node_modules/@opentelemetry/instrumentation/build/esm/platform/index.js\n../../node_modules/@prisma/instrumentation/node_modules/@opentelemetry/instrumentation/build/esm/index.js\n../../node_modules/@prisma/instrumentation/dist/chunk-L6V5ZEAH.js\n../../node_modules/@prisma/instrumentation/dist/index.js\n../../node_modules/@sentry/nextjs/node_modules/@sentry/node/cjs/index.js\n../../node_modules/@sentry/nextjs/cjs/index.server.js\n./app/api/test-success/route.ts",
"timestamp": "[[timestamp]]"
},
{
"category": "console",
"level": "log",
"message": "\u001b[35mevent\u001b[39m - compiled successfully in 91 ms (502 modules)",
"timestamp": "[[timestamp]]"
},
{
"category": "http",
"data": {
"method": "GET",
"url": "http://localhost:3000/__nextjs_original-stack-frame?isServer=false&isEdgeServer=false&isAppDirectory=true&errorMessage=Error%3A+This+is+an+error&file=webpack-internal%3A%2F%2F%2F%28sc_server%29%2F.%2Fapp%2Fapi%2Ftest-error%2Froute.ts&methodName=GET%241&arguments=&lineNumber=23&column=86"
},
"level": "error",
"timestamp": "[[timestamp]]",
"type": "http"
},
{
"category": "http",
"data": {
"method": "GET",
"url": "http://localhost:3000/__nextjs_original-stack-frame?isServer=false&isEdgeServer=false&isAppDirectory=true&errorMessage=Error%3A+This+is+an+error&file=webpack-internal%3A%2F%2F%2F%28sc_server%29%2F.%2Fapp%2Fapi%2Ftest-error%2Froute.ts&methodName=Object.apply&arguments=&lineNumber=65&column=10"
},
"level": "error",
"timestamp": "[[timestamp]]",
"type": "http"
}
],
"contexts": {
Expand Down Expand Up @@ -88,161 +65,144 @@
"name": "macOS",
"version": "14.2"
},
"otel": {
"resource": {
"service.name": "node",
"service.namespace": "sentry",
"service.version": "8.0.0-beta.1",
"telemetry.sdk.language": "nodejs",
"telemetry.sdk.name": "opentelemetry",
"telemetry.sdk.version": "1.21.0"
}
},
"runtime": {
"name": "node",
"version": "v20.12.1"
},
"trace": {
"data": {
"http.method": "GET",
"http.response.status_code": 200,
"http.route": "/api/test-error/route",
"http.status_code": 200,
"http.target": "/api/test-error",
"next.route": "/api/test-error/route",
"next.rsc": false,
"next.span_name": "GET /api/test-error/route",
"next.span_type": "BaseServer.handleRequest",
"otel.kind": "SERVER",
"sentry.op": "http.server",
"sentry.origin": "auto.function.nextjs",
"sentry.sample_rate": 1,
"sentry.source": "route"
},
"op": "http.server",
"origin": "auto.function.nextjs",
"parent_span_id": "[[ID3]]",
"span_id": "[[ID4]]",
"span_id": "[[ID3]]",
"status": "ok",
"tags": {
"http.status_code": "200"
},
"trace_id": "[[ID2]]"
}
},
"environment": "qa",
"event_id": "[[ID1]]",
"modules": {
"ansi-styles": "4.3.0",
"balanced-match": "1.0.2",
"brace-expansion": "2.0.1",
"caniuse-lite": "1.0.30001610",
"commondir": "1.0.1",
"estree-walker": "2.0.2",
"fs.realpath": "1.0.0",
"function-bind": "1.1.2",
"has-flag": "4.0.0",
"hasown": "2.0.2",
"inflight": "1.0.6",
"inherits": "2.0.4",
"is-core-module": "2.13.1",
"is-reference": "1.2.1",
"js-tokens": "4.0.0",
"localforage": "1.10.0",
"loose-envify": "1.4.0",
"nanoid": "3.3.7",
"next": "13.2.0",
"once": "1.4.0",
"picocolors": "1.0.0",
"picomatch": "2.3.1",
"postcss": "8.4.14",
"react": "18.2.0",
"react-dom": "18.2.0",
"resolve": "1.22.8",
"rollup": "2.78.0",
"scheduler": "0.23.0",
"source-map-js": "1.2.0",
"stacktrace-parser": "0.1.10",
"styled-jsx": "5.1.1",
"wrappy": "1.0.2"
},
"modules": {},
"platform": "node",
"request": {
"cookies": {},
"headers": {
"accept": "*/*",
"accept-encoding": "gzip, deflate, br",
"accept-language": "en-US,en;q=0.5",
"baggage": "sentry-environment=qa,sentry-public_key=3b6c388182fb435097f41d181be2b2ba,sentry-trace_id=1e639b3a12f042eb99339c3baac20ffa",
"cache-control": "no-cache",
"connection": "keep-alive",
"host": "localhost:3030",
"pragma": "no-cache",
"referer": "http://localhost:3030/test-route-handlers",
"sec-fetch-dest": "empty",
"sec-fetch-mode": "cors",
"sec-fetch-site": "same-origin",
"sentry-trace": "1e639b3a12f042eb99339c3baac20ffa-84813d02de47733d",
"user-agent": "[[user-agent]]"
},
"url": "http://localhost:3030"
},
"sdk": {
"integrations": [
"InboundFilters",
"FunctionToString",
"LinkedErrors",
"RequestData",
"Console",
"Undici",
"OnUncaughtException",
"OnUnhandledRejection",
"ContextLines",
"LocalVariables",
"Context",
"Modules",
"RewriteFrames",
"Http",
"OnUncaughtException"
"Express",
"Fastify",
"Graphql",
"Mongo",
"Mongoose",
"Mysql",
"Mysql2",
"Postgres",
"Nest",
"Hapi",
"Koa",
"RequestIsolationScope",
"DistDirRewriteFrames"
],
"name": "sentry.javascript.nextjs",
"packages": [
{
"name": "npm:@sentry/nextjs",
"version": "7.110.1"
"version": "8.0.0-beta.1"
},
{
"name": "npm:@sentry/node",
"version": "7.110.1"
"version": "8.0.0-beta.1"
}
],
"version": "7.110.1"
"version": "8.0.0-beta.1"
},
"server_name": "D9M3PY4LQ7.local",
"spans": [
{
"data": {
"http.method": "GET",
"http.query": "?isServer=false&isEdgeServer=false&isAppDirectory=true&errorMessage=Error%3A+This+is+an+error&file=webpack-internal%3A%2F%2F%2F%28sc_server%29%2F.%2Fapp%2Fapi%2Ftest-error%2Froute.ts&methodName=GET%241&arguments=&lineNumber=23&column=86",
"sentry.op": "http.client",
"sentry.origin": "auto.http.node.undici"
"next.route": "/api/test-error",
"next.span_name": "resolve page components",
"next.span_type": "NextNodeServer.findPageComponents",
"otel.kind": "INTERNAL",
"sentry.origin": "manual"
},
"description": "GET http://localhost:3000/__nextjs_original-stack-frame",
"op": "http.client",
"origin": "auto.http.node.undici",
"parent_span_id": "[[ID4]]",
"description": "resolve page components",
"origin": "manual",
"parent_span_id": "[[ID3]]",
"span_id": "[[ID4]]",
"start_timestamp": "[[timestamp]]",
"status": "ok",
"timestamp": "[[timestamp]]",
"trace_id": "[[ID2]]"
},
{
"data": {
"next.route": "/api/test-error/route",
"next.span_name": "executing api route (app) /api/test-error/route",
"next.span_type": "AppRouteRouteHandlers.runHandler",
"otel.kind": "INTERNAL",
"sentry.origin": "manual"
},
"description": "executing api route (app) /api/test-error/route",
"origin": "manual",
"parent_span_id": "[[ID3]]",
"span_id": "[[ID5]]",
"start_timestamp": "[[timestamp]]",
"status": "internal_error",
"status": "ok",
"timestamp": "[[timestamp]]",
"trace_id": "[[ID2]]"
},
{
"data": {
"http.method": "GET",
"http.query": "?isServer=false&isEdgeServer=false&isAppDirectory=true&errorMessage=Error%3A+This+is+an+error&file=webpack-internal%3A%2F%2F%2F%28sc_server%29%2F.%2Fapp%2Fapi%2Ftest-error%2Froute.ts&methodName=Object.apply&arguments=&lineNumber=65&column=10",
"sentry.op": "http.client",
"sentry.origin": "auto.http.node.undici"
"next.span_name": "start response",
"next.span_type": "NextNodeServer.startResponse",
"otel.kind": "INTERNAL",
"sentry.origin": "manual"
},
"description": "GET http://localhost:3000/__nextjs_original-stack-frame",
"op": "http.client",
"origin": "auto.http.node.undici",
"parent_span_id": "[[ID4]]",
"description": "start response",
"origin": "manual",
"parent_span_id": "[[ID3]]",
"span_id": "[[ID6]]",
"start_timestamp": "[[timestamp]]",
"status": "internal_error",
"status": "ok",
"timestamp": "[[timestamp]]",
"trace_id": "[[ID2]]"
}
],
"start_timestamp": "[[timestamp]]",
"tags": {
"http.status_code": "200",
"runtime": "node",
"transaction": "GET /api/test-error"
},
"timestamp": "[[timestamp]]",
"transaction": "GET /api/test-error",
"transaction": "GET /api/test-error/route",
"transaction_info": {
"source": "route"
},
Expand Down
Loading