-
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit 307a3db
authored
feat(node): add continuous profiling mode (#12124)
This PR introduce a new continuous profiling mode. This mode is
exclusive from the current mode which considers starting and stopping
profiles on a per span basis.
I've picked the interval duration of 5s as somewhat arbitrarily. The
idea is that we dont want profiles to grow too large, because that might
become a performance issue in the event that we have a lot of deep stack
samples to process.
Since profiling mode is exclusive, we will require users to add a
profilerMode (subject to change) as the SDK option (this is subject to
change as we align the APIs cross sdks). In terms of convenience, we are
likely also going to add a Sentry.profiler.start/stop methods so that
users can have access as to when they can start and stop the profiler
(not implemented as we havent standardized on the approach yet) -
currently this relies on
getIntegrationByName("ProfilingIntegration").profiler.stop
Since the UI does not support this mode yet, I will hide the
profilerMode hidden and only allow the current automated instrumentation1 parent 321f65a commit 307a3dbCopy full SHA for 307a3db
File tree
Expand file treeCollapse file tree
1 file changed
+155
-60
lines changedFilter options
- packages/profiling-node/bindings
Expand file treeCollapse file tree
1 file changed
+155
-60
lines changed
0 commit comments