small code style changes

Author: s1gr1d

packages/node/src/integrations/tracing/redis.ts

@@ -29,10 +29,9 @@ let _redisOptions: RedisOptions = {};
 export const instrumentRedis = generateInstrumentOnce(INTEGRATION_NAME, () => {
   return new IORedisInstrumentation({
     responseHook: (span, redisCommand, cmdArgs, response) => {
-      const safeKey = getCacheKeySafely(redisCommand, cmdArgs);
-
       span.setAttribute(SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN, 'auto.db.otel.redis');
 
+      const safeKey = getCacheKeySafely(redisCommand, cmdArgs);
       const cacheOperation = getCacheOperation(redisCommand);
 
       if (

packages/node/src/utils/redisCache.ts

@@ -56,14 +56,17 @@ export function getCacheKeySafely(redisCommand: string, cmdArgs: IORedisCommandA
 
 /** Determines whether a redis operation should be considered as "cache operation" by checking if a key is prefixed.
  *  We only support certain commands (such as 'set', 'get', 'mget'). */
-export function shouldConsiderForCache(redisCommand: string, key: string[], prefixes: string[]): boolean {
+export function shouldConsiderForCache(redisCommand: string, keys: string[], prefixes: string[]): boolean {
   if (!getCacheOperation(redisCommand)) {
     return false;
   }
 
-  return key.reduce((prev, key) => {
-    return prev || keyHasPrefix(key, prefixes);
-  }, false);
+  for (const key of keys) {
+    if (keyHasPrefix(key, prefixes)) {
+      return true;
+    }
+  }
+  return false;
 }
 
 /** Calculates size based on the cache response value */

packages/opentelemetry/src/utils/parseSpanDescription.ts

@@ -51,7 +51,7 @@ export function parseSpanDescription(span: AbstractSpan): SpanDescription {
 
   // If db.type exists then this is a database call span
   // If the Redis DB is used as a cache, the span description should not be changed
-  if (dbSystem && (!attributes[SEMANTIC_ATTRIBUTE_SENTRY_OP] || !opIsCache)) {
+  if (dbSystem && !opIsCache) {
     return descriptionForDbSystem({ attributes, name });
   }