Skip to content

Commit 020f6de

Browse files
committed
build: Check for circular dep with madge
Madge (https://www.npmjs.com/package/madge) is a library that can traverse module dependency trees to check for circular dependencies. We can leverage it using `madge --circular /path/to/index.ts` to make sure that our packages don't contain circular deps. On average madge takes around 2-3 sec, so we are not sacrificing a ton of CI time.
1 parent a8b6a23 commit 020f6de

File tree

17 files changed

+34
-17
lines changed

17 files changed

+34
-17
lines changed

packages/angular/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,8 @@
3535
"npm-run-all": "^4.1.2",
3636
"prettier": "1.19.0",
3737
"rimraf": "^2.6.3",
38-
"typescript": "3.7.5"
38+
"typescript": "3.7.5",
39+
"madge": "4.0.2"
3940
},
4041
"scripts": {
4142
"build": "run-p build:es5 build:esm",

packages/browser/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,8 @@
5151
"rollup-plugin-typescript2": "^0.21.0",
5252
"sinon": "^7.3.2",
5353
"typescript": "3.7.5",
54-
"webpack": "^4.30.0"
54+
"webpack": "^4.30.0",
55+
"madge": "4.0.2"
5556
},
5657
"scripts": {
5758
"build": "run-s build:dist build:esm build:bundle",

packages/core/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,8 @@
2828
"npm-run-all": "^4.1.2",
2929
"prettier": "1.19.0",
3030
"rimraf": "^2.6.3",
31-
"typescript": "3.7.5"
31+
"typescript": "3.7.5",
32+
"madge": "4.0.2"
3233
},
3334
"scripts": {
3435
"build": "run-p build:es5 build:esm",

packages/eslint-plugin-sdk/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,8 @@
2424
"devDependencies": {
2525
"mocha": "^6.2.0",
2626
"prettier": "1.19.0",
27-
"typescript": "3.7.5"
27+
"typescript": "3.7.5",
28+
"madge": "4.0.2"
2829
},
2930
"scripts": {
3031
"link:yarn": "yarn link",

packages/gatsby/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,8 @@
4040
"prettier": "1.19.0",
4141
"react": "^17.0.0",
4242
"rimraf": "^2.6.3",
43-
"typescript": "3.7.5"
43+
"typescript": "3.7.5",
44+
"madge": "4.0.2"
4445
},
4546
"scripts": {
4647
"build": "run-p build:es5 build:esm",

packages/hub/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,8 @@
2626
"npm-run-all": "^4.1.2",
2727
"prettier": "1.19.0",
2828
"rimraf": "^2.6.3",
29-
"typescript": "3.7.5"
29+
"typescript": "3.7.5",
30+
"madge": "4.0.2"
3031
},
3132
"scripts": {
3233
"build": "run-p build:es5 build:esm",

packages/integrations/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,8 @@
3333
"rollup-plugin-node-resolve": "^4.2.3",
3434
"rollup-plugin-terser": "^4.0.4",
3535
"rollup-plugin-typescript2": "^0.21.0",
36-
"typescript": "3.7.5"
36+
"typescript": "3.7.5",
37+
"madge": "4.0.2"
3738
},
3839
"scripts": {
3940
"build": "run-p build:es5 build:esm build:bundle",

packages/minimal/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,8 @@
2626
"npm-run-all": "^4.1.2",
2727
"prettier": "1.19.0",
2828
"rimraf": "^2.6.3",
29-
"typescript": "3.7.5"
29+
"typescript": "3.7.5",
30+
"madge": "4.0.2"
3031
},
3132
"scripts": {
3233
"build": "run-p build:es5 build:esm",

packages/nextjs/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,8 @@
3131
"@types/webpack": "^5.28.0",
3232
"eslint": "7.20.0",
3333
"next": "10.1.3",
34-
"rimraf": "3.0.2"
34+
"rimraf": "3.0.2",
35+
"madge": "4.0.2"
3536
},
3637
"peerDependencies": {
3738
"next": "^10.0.8",

packages/node/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,8 @@
3838
"npm-run-all": "^4.1.2",
3939
"prettier": "1.19.0",
4040
"rimraf": "^2.6.3",
41-
"typescript": "3.7.5"
41+
"typescript": "3.7.5",
42+
"madge": "4.0.2"
4243
},
4344
"scripts": {
4445
"build": "run-p build:es5 build:esm",

packages/react/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,8 @@
5353
"react-test-renderer": "^16.13.1",
5454
"redux": "^4.0.5",
5555
"rimraf": "^2.6.3",
56-
"typescript": "3.7.5"
56+
"typescript": "3.7.5",
57+
"madge": "4.0.2"
5758
},
5859
"scripts": {
5960
"build": "run-p build:es5 build:esm",

packages/serverless/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,8 @@
4242
"prettier": "1.19.0",
4343
"read-pkg": "^5.2.0",
4444
"rimraf": "^2.6.3",
45-
"typescript": "3.7.5"
45+
"typescript": "3.7.5",
46+
"madge": "4.0.2"
4647
},
4748
"scripts": {
4849
"build": "run-s build:es build:awslambda-layer",

packages/tracing/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,8 @@
3838
"rollup-plugin-node-resolve": "^4.2.3",
3939
"rollup-plugin-terser": "^4.0.4",
4040
"rollup-plugin-typescript2": "^0.21.0",
41-
"typescript": "3.7.5"
41+
"typescript": "3.7.5",
42+
"madge": "4.0.2"
4243
},
4344
"scripts": {
4445
"build": "run-p build:es5 build:esm build:bundle",

packages/types/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,8 @@
1919
"@sentry-internal/eslint-config-sdk": "6.5.0",
2020
"npm-run-all": "^4.1.2",
2121
"prettier": "1.19.0",
22-
"typescript": "3.7.5"
22+
"typescript": "3.7.5",
23+
"madge": "4.0.2"
2324
},
2425
"scripts": {
2526
"build": "run-p build:es5 build:esm",

packages/utils/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,8 @@
2626
"npm-run-all": "^4.1.2",
2727
"prettier": "1.19.0",
2828
"rimraf": "^2.6.3",
29-
"typescript": "3.7.5"
29+
"typescript": "3.7.5",
30+
"madge": "4.0.2"
3031
},
3132
"scripts": {
3233
"build": "run-p build:es5 build:esm",

packages/vue/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,8 @@
4242
"rollup-plugin-typescript2": "^0.21.0",
4343
"typescript": "3.7.5",
4444
"vue": "^2.6",
45-
"vue-router": "^3.0.1"
45+
"vue-router": "^3.0.1",
46+
"madge": "4.0.2"
4647
},
4748
"scripts": {
4849
"build": "run-p build:es5 build:esm build:bundle",

packages/wasm/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,8 @@
3636
"rollup-plugin-node-resolve": "^4.2.3",
3737
"rollup-plugin-terser": "^4.0.4",
3838
"rollup-plugin-typescript2": "^0.21.0",
39-
"typescript": "3.7.5"
39+
"typescript": "3.7.5",
40+
"madge": "4.0.2"
4041
},
4142
"scripts": {
4243
"build": "run-p build:es5 build:esm build:bundle",

0 commit comments

Comments
 (0)