Skip to content

Commit 0550701

Browse files
committed
cursor cleanup
1 parent 5da68ef commit 0550701

File tree

4 files changed

+10
-8
lines changed
  • dev-packages/browser-integration-tests/suites/tracing/metrics

4 files changed

+10
-8
lines changed

dev-packages/browser-integration-tests/suites/tracing/metrics/pageload-measure-spans-firefox/test.ts renamed to dev-packages/browser-integration-tests/suites/tracing/metrics/pageload-measure-spans-domexception-details/test.ts

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,10 @@ import type { Event } from '@sentry/core';
33
import { sentryTest } from '../../../../utils/fixtures';
44
import { getFirstSentryEnvelopeRequest, shouldSkipTracingTest } from '../../../../utils/helpers';
55

6+
// This is a regression test for https://github.com/getsentry/sentry-javascript/issues/16347
7+
68
sentryTest(
7-
'should handle Firefox permission denial gracefully and still create measure spans',
9+
'should handle permission denial gracefully and still create measure spans',
810
async ({ getLocalTestUrl, page }) => {
911
if (shouldSkipTracingTest()) {
1012
sentryTest.skip();
@@ -17,18 +19,18 @@ sentryTest(
1719
const measureSpans = eventData.spans?.filter(({ op }) => op === 'measure');
1820
expect(measureSpans?.length).toBe(2); // Both measures should create spans
1921

20-
// Test 1: Verify the firefox-test-measure span exists but has no detail
21-
const firefoxMeasure = measureSpans?.find(span => span.description === 'firefox-test-measure');
22-
expect(firefoxMeasure).toBeDefined();
23-
expect(firefoxMeasure?.data).toMatchObject({
22+
// Test 1: Verify the restricted-test-measure span exists but has no detail
23+
const restrictedMeasure = measureSpans?.find(span => span.description === 'restricted-test-measure');
24+
expect(restrictedMeasure).toBeDefined();
25+
expect(restrictedMeasure?.data).toMatchObject({
2426
'sentry.op': 'measure',
2527
'sentry.origin': 'auto.resource.browser.metrics',
2628
});
2729

2830
// Verify no detail attributes were added due to the permission error
29-
const firefoxDataKeys = Object.keys(firefoxMeasure?.data || {});
30-
const firefoxDetailKeys = firefoxDataKeys.filter(key => key.includes('detail'));
31-
expect(firefoxDetailKeys).toHaveLength(0);
31+
const restrictedDataKeys = Object.keys(restrictedMeasure?.data || {});
32+
const restrictedDetailKeys = restrictedDataKeys.filter(key => key.includes('detail'));
33+
expect(restrictedDetailKeys).toHaveLength(0);
3234

3335
// Test 2: Verify the normal measure still captures detail correctly
3436
const normalMeasure = measureSpans?.find(span => span.description === 'normal-measure');

0 commit comments

Comments
 (0)