sad

Author: Luca Forstner

packages/opentelemetry-node/src/spanprocessor.ts

@@ -40,12 +40,17 @@ export class SentrySpanProcessor implements OtelSpanProcessor {
 
       // If event has already set `trace` context, use that one.
       event.contexts = {
+        ...event.contexts,
         trace: {
+          ...event.contexts?.trace,
+          // We are overriding values here. In theory this is bad and we definitely need to change that in the future.
+          // The reason we need to override here is because in the core sdk we apply span data to the trace context at the time of capturing, and apply the propagation context if there is no span on the scope.
+          // In the OTEL SDK we never have a span on the scope, meaning that the propagation context is applied.
+          // If we now didn't overwrite the trace context here we would end up with the values of the propagation context instead but we want the data from the span.
           trace_id: otelSpanContext.traceId,
           span_id: otelSpanContext.spanId,
           parent_span_id: otelSpan.parentSpanId,
         },
-        ...event.contexts,
       };
 
       return event;