Abhi code review

Author: timfish

packages/node/src/integrations/contextlines.ts

@@ -3,20 +3,14 @@ import { Event, EventProcessor, Integration } from '@sentry/types';
 import { addContextToFrame } from '@sentry/utils';
 import { readFile } from 'fs';
 import { LRUMap } from 'lru_map';
+import { promisify } from 'util';
 
 import { NodeClient } from '../client';
 
 const FILE_CONTENT_CACHE = new LRUMap<string, string | null>(100);
 const DEFAULT_LINES_OF_CONTEXT = 7;
 
-function readTextFileAsync(path: string): Promise<string> {
-  return new Promise((resolve, reject) => {
-    readFile(path, 'utf8', (err, data) => {
-      if (err) reject(err);
-      else resolve(data);
-    });
-  });
-}
+const readFileAsync = promisify(readFile);
 
 /**
  * Resets the file cache. Exists for testing purposes.
@@ -28,10 +22,11 @@ export function resetFileContentCache(): void {
 
 interface ContextLinesOptions {
   /**
-   * Sets the number of context lines for each frame when loading a file
+   * Sets the number of context lines for each frame when loading a file.
+   * Defaults to 7.
    *
    * Set to 0 to disable loading and inclusion of source files.
-   * */
+   **/
   frameContextLines?: number;
 }
 
@@ -125,7 +120,7 @@ async function readSourceFiles(filenames: Set<string>): Promise<Record<string, s
 
     let content: string | null = null;
     try {
-      content = await readTextFileAsync(filename);
+      content = await readFileAsync(filename, { encoding: 'utf8' });
     } catch (_) {
       //
     }