Extract getDefaultNodeClientOptions into helper module

Author: Luca Forstner

packages/node/test/client.test.ts

@@ -1,21 +1,11 @@
 import { Scope, SessionFlusher } from '@sentry/hub';
-import { NoopTransport } from '@sentry/core';
 
 import { NodeClient } from '../src';
 import { setupNodeTransport } from '../src/transports';
-import { NodeClientOptions } from '../src/types';
+import { getDefaultNodeClientOptions } from './helper/node-client-options';
 
 const PUBLIC_DSN = 'https://username@domain/123';
 
-function getDefaultNodeClientOptions(options: Partial<NodeClientOptions> = {}): NodeClientOptions {
-  return {
-    integrations: [],
-    transport: NoopTransport,
-    stackParser: () => [],
-    ...options,
-  };
-}
-
 describe('NodeClient', () => {
   let client: NodeClient;
 

packages/node/test/handlers.test.ts

@@ -1,6 +1,6 @@
 import * as sentryCore from '@sentry/core';
-import { Hub } from '@sentry/hub';
 import * as sentryHub from '@sentry/hub';
+import { Hub } from '@sentry/hub';
 import { Transaction } from '@sentry/tracing';
 import { Runtime } from '@sentry/types';
 import { SentryError } from '@sentry/utils';
@@ -19,16 +19,7 @@ import {
 } from '../src/handlers';
 import * as SDK from '../src/sdk';
 import { setupNodeTransport } from '../src/transports';
-import { NodeClientOptions } from '../src/types';
-
-function getDefaultNodeClientOptions(options: Partial<NodeClientOptions> = {}): NodeClientOptions {
-  return {
-    integrations: [],
-    transport: sentryCore.NoopTransport,
-    stackParser: () => [],
-    ...options,
-  };
-}
+import { getDefaultNodeClientOptions } from './helper/node-client-options';
 
 describe('parseRequest', () => {
   let mockReq: { [key: string]: any };

packages/node/test/helper/node-client-options.ts

@@ -0,0 +1,12 @@
+import { NoopTransport } from '@sentry/core';
+
+import { NodeClientOptions } from '../../src/types';
+
+export function getDefaultNodeClientOptions(options: Partial<NodeClientOptions> = {}): NodeClientOptions {
+  return {
+    integrations: [],
+    transport: NoopTransport,
+    stackParser: () => [],
+    ...options,
+  };
+}

packages/node/test/index.test.ts

@@ -1,4 +1,4 @@
-import { initAndBind, SDK_VERSION, NoopTransport } from '@sentry/core';
+import { initAndBind, SDK_VERSION } from '@sentry/core';
 import { getMainCarrier } from '@sentry/hub';
 import { Integration } from '@sentry/types';
 import { createStackParser } from '@sentry/utils';
@@ -19,7 +19,7 @@ import {
 import { ContextLines, LinkedErrors } from '../src/integrations';
 import { nodeStackParser } from '../src/stack-parser';
 import { setupNodeTransport } from '../src/transports';
-import { NodeClientOptions } from '../src/types';
+import { getDefaultNodeClientOptions } from './helper/node-client-options';
 
 const stackParser = createStackParser(nodeStackParser);
 
@@ -31,15 +31,6 @@ jest.mock('@sentry/core', () => {
   };
 });
 
-function getDefaultNodeClientOptions(options: Partial<NodeClientOptions> = {}): NodeClientOptions {
-  return {
-    integrations: [],
-    transport: NoopTransport,
-    stackParser: () => [],
-    ...options,
-  };
-}
-
 const dsn = 'https://[email protected]/4291';
 
 // eslint-disable-next-line no-var

packages/node/test/integrations/http.test.ts

@@ -1,6 +1,6 @@
 import * as sentryCore from '@sentry/core';
-import { Hub } from '@sentry/hub';
 import * as hubModule from '@sentry/hub';
+import { Hub } from '@sentry/hub';
 import { addExtensionMethods, Span, TRACEPARENT_REGEXP, Transaction } from '@sentry/tracing';
 import { parseSemver } from '@sentry/utils';
 import * as http from 'http';
@@ -12,19 +12,10 @@ import { Breadcrumb } from '../../src';
 import { NodeClient } from '../../src/client';
 import { Http as HttpIntegration } from '../../src/integrations/http';
 import { setupNodeTransport } from '../../src/transports';
-import { NodeClientOptions } from '../../src/types';
+import { getDefaultNodeClientOptions } from '../helper/node-client-options';
 
 const NODE_VERSION = parseSemver(process.versions.node);
 
-function getDefaultNodeClientOptions(options: Partial<NodeClientOptions> = {}): NodeClientOptions {
-  return {
-    integrations: [],
-    transport: sentryCore.NoopTransport,
-    stackParser: () => [],
-    ...options,
-  };
-}
-
 describe('tracing', () => {
   function createTransactionOnScope() {
     const options = getDefaultNodeClientOptions({

packages/node/test/integrations/linkederrors.test.ts

@@ -1,26 +1,16 @@
 import { ExtendedError } from '@sentry/types';
 import { createStackParser } from '@sentry/utils';
-import { NoopTransport } from '@sentry/core';
 
 import { Event, NodeClient } from '../../src';
 import { LinkedErrors } from '../../src/integrations/linkederrors';
 import { nodeStackParser } from '../../src/stack-parser';
 import { setupNodeTransport } from '../../src/transports';
-import { NodeClientOptions } from '../../src/types';
+import { getDefaultNodeClientOptions } from '../helper/node-client-options';
 
 const stackParser = createStackParser(nodeStackParser);
 
 let linkedErrors: any;
 
-function getDefaultNodeClientOptions(options: Partial<NodeClientOptions> = {}): NodeClientOptions {
-  return {
-    integrations: [],
-    transport: NoopTransport,
-    stackParser: () => [],
-    ...options,
-  };
-}
-
 describe('LinkedErrors', () => {
   beforeEach(() => {
     linkedErrors = new LinkedErrors();

packages/node/test/transports/setup.test.ts

@@ -3,7 +3,7 @@ import { FakeTransport } from '@sentry/core/test/mocks/transport';
 import { HTTPSTransport, HTTPTransport, setupNodeTransport } from '@sentry/node/src/transports';
 
 import { makeNodeTransport } from '../../src/transports/new';
-import { NodeClientOptions } from '../../src/types';
+import { getDefaultNodeClientOptions } from '../helper/node-client-options';
 
 jest.mock('../../src/transports/new', () => {
   const original = jest.requireActual('../../src/transports/new');
@@ -16,15 +16,6 @@ jest.mock('../../src/transports/new', () => {
   };
 });
 
-function getDefaultNodeClientOptions(options: Partial<NodeClientOptions> = {}): NodeClientOptions {
-  return {
-    integrations: [],
-    transport: NoopTransport,
-    stackParser: () => [],
-    ...options,
-  };
-}
-
 const DSN = 'https://username@domain/123';
 
 describe('setupNodeTransport', () => {