Skip to content

Commit 108f53f

Browse files
committed
more review comments
1 parent 82bfc58 commit 108f53f

File tree

2 files changed

+12
-5
lines changed

2 files changed

+12
-5
lines changed

MIGRATION.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -114,9 +114,9 @@ Sentry SDK requires the fetch API to be available in the environment.
114114

115115
## Integrations
116116

117-
We moved optional integrations from their own package (`@sentry/integrations`) to `@sentry/browser` and `@sentry/node`.
117+
We moved pluggable integrations from their own package (`@sentry/integrations`) to `@sentry/browser` and `@sentry/node`.
118118

119-
Integrations that are now exported from `@sentry/browser` :
119+
Integrations that are now exported from `@sentry/browser` (or framework-specific packages like `@sentry/react`):
120120

121121
- httpClientIntegration
122122
- contextLinesIntegration
@@ -127,10 +127,10 @@ Integrations that are now exported from `@sentry/node` and `@sentry/browser` (or
127127

128128
- captureConsoleIntegration
129129
- debugIntegration
130-
- dedupeIntegration
131130
- extraErrorDataIntegration
132131
- rewriteFramesIntegration
133132
- sessionTimingIntegration
133+
- dedupeIntegration (enabled by default, not pluggable)
134134

135135
# Deprecations in 7.x
136136

packages/browser/rollup.bundle.config.mjs

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,14 @@ if (targets.some(target => target !== 'es5' && target !== 'es6')) {
1010

1111
const browserPluggableIntegrationFiles = ['contextlines', 'httpclient', 'reportingobserver'];
1212

13-
const coreIntegrationFiles = ['captureconsole', 'debug', 'dedupe', 'extraerrordata', 'rewriteframes', 'sessiontiming'];
13+
const corePluggableIntegrationFiles = [
14+
'captureconsole',
15+
'debug',
16+
'dedupe',
17+
'extraerrordata',
18+
'rewriteframes',
19+
'sessiontiming',
20+
];
1421

1522
targets.forEach(jsVersion => {
1623
const baseBundleConfig = makeBaseBundleConfig({
@@ -41,7 +48,7 @@ targets.forEach(jsVersion => {
4148
builds.push(...makeBundleConfigVariants(integrationsBundleConfig));
4249
});
4350

44-
coreIntegrationFiles.forEach(integrationName => {
51+
corePluggableIntegrationFiles.forEach(integrationName => {
4552
const integrationsBundleConfig = makeBaseBundleConfig({
4653
bundleType: 'addon',
4754
entrypoints: [`src/integrations-bundle/index.${integrationName}.ts`],

0 commit comments

Comments
 (0)