File tree Expand file tree Collapse file tree 4 files changed +18
-3
lines changed Expand file tree Collapse file tree 4 files changed +18
-3
lines changed Original file line number Diff line number Diff line change @@ -219,6 +219,15 @@ export abstract class BaseClient<O extends ClientOptions> implements Client<O> {
219
219
return this . _options ;
220
220
}
221
221
222
+ /**
223
+ * @see SdkMetadata in @sentry/types
224
+ *
225
+ * @return The metadata of the SDK
226
+ */
227
+ public getSdkMetadata ( ) : O [ '_metadata' ] {
228
+ return this . _options . _metadata ;
229
+ }
230
+
222
231
/**
223
232
* @inheritDoc
224
233
*/
Original file line number Diff line number Diff line change @@ -18,13 +18,13 @@ export async function getReplayEvent({
18
18
19
19
if ( preparedEvent ) {
20
20
// extract the SDK name because `client._prepareEvent` doesn't add it to the event
21
- const metadata = client . getOptions ( ) && client . getOptions ( ) . _metadata ;
21
+ const metadata = client . getSdkMetadata && client . getSdkMetadata ( ) ;
22
22
const { name } = ( metadata && metadata . sdk ) || { } ;
23
23
24
24
preparedEvent . sdk = {
25
25
...preparedEvent . sdk ,
26
26
version : __SENTRY_REPLAY_VERSION__ ,
27
- name,
27
+ name : name || 'sentry.javascript.unknown' ,
28
28
} ;
29
29
}
30
30
Original file line number Diff line number Diff line change @@ -69,6 +69,13 @@ export interface Client<O extends ClientOptions = ClientOptions> {
69
69
/** Returns the current options. */
70
70
getOptions ( ) : O ;
71
71
72
+ /**
73
+ * @inheritdoc
74
+ *
75
+ * TODO (v8): Make this a required method.
76
+ */
77
+ getSdkMetadata ?( ) : O [ '_metadata' ] ;
78
+
72
79
/**
73
80
* Returns the transport that is used by the client.
74
81
* Please note that the transport gets lazy initialized so it will only be there once the first event has been sent.
Original file line number Diff line number Diff line change @@ -109,7 +109,6 @@ export function makeTerserPlugin() {
109
109
'_support' ,
110
110
// TODO: Get rid of these once we use the SDK to send replay events
111
111
'_prepareEvent' , // replay uses client._prepareEvent
112
- '_metadata' , // replay uses client.getOptions()._metadata
113
112
] ,
114
113
} ,
115
114
} ,
You can’t perform that action at this time.
0 commit comments