Skip to content

Commit 10d59eb

Browse files
committed
feat(core): Add getSdkMetadata to Client
1 parent a23bda5 commit 10d59eb

File tree

4 files changed

+18
-3
lines changed

4 files changed

+18
-3
lines changed

packages/core/src/baseclient.ts

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -219,6 +219,15 @@ export abstract class BaseClient<O extends ClientOptions> implements Client<O> {
219219
return this._options;
220220
}
221221

222+
/**
223+
* @see SdkMetadata in @sentry/types
224+
*
225+
* @return The metadata of the SDK
226+
*/
227+
public getSdkMetadata(): O['_metadata'] {
228+
return this._options._metadata;
229+
}
230+
222231
/**
223232
* @inheritDoc
224233
*/

packages/replay/src/util/getReplayEvent.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,13 +18,13 @@ export async function getReplayEvent({
1818

1919
if (preparedEvent) {
2020
// extract the SDK name because `client._prepareEvent` doesn't add it to the event
21-
const metadata = client.getOptions() && client.getOptions()._metadata;
21+
const metadata = client.getSdkMetadata && client.getSdkMetadata();
2222
const { name } = (metadata && metadata.sdk) || {};
2323

2424
preparedEvent.sdk = {
2525
...preparedEvent.sdk,
2626
version: __SENTRY_REPLAY_VERSION__,
27-
name,
27+
name: name || 'sentry.javascript.unknown',
2828
};
2929
}
3030

packages/types/src/client.ts

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,13 @@ export interface Client<O extends ClientOptions = ClientOptions> {
6969
/** Returns the current options. */
7070
getOptions(): O;
7171

72+
/**
73+
* @inheritdoc
74+
*
75+
* TODO (v8): Make this a required method.
76+
*/
77+
getSdkMetadata?(): O['_metadata'];
78+
7279
/**
7380
* Returns the transport that is used by the client.
7481
* Please note that the transport gets lazy initialized so it will only be there once the first event has been sent.

rollup/plugins/bundlePlugins.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,6 @@ export function makeTerserPlugin() {
109109
'_support',
110110
// TODO: Get rid of these once we use the SDK to send replay events
111111
'_prepareEvent', // replay uses client._prepareEvent
112-
'_metadata', // replay uses client.getOptions()._metadata
113112
],
114113
},
115114
},

0 commit comments

Comments
 (0)